-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baseline data simulation #218
Conversation
Code Coverage Summary
Diff against main
Results for commit: e1d7c23 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Thanks, @gravesti . I'll review today @mattsecrest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gravesti would you mind adding a functional vignette? I think the ones there are more like design documents and do not directly leverage the new functions. I can kind of figure it out from context but a proper vignette would help greatly.
@mattsecrest See the new vignette |
@gravesti thanks for the vignette, this looks great! Thanks so much for putting together. Just curious per my previous question on whether we want to overload |
@gravesti after meeting: let's merge, review and clean redundant features after the fact. |
And also see what the missing features are for survival |
Pull Request