Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] add camera #28

Merged
merged 7 commits into from
Sep 8, 2024
Merged

[Feat] add camera #28

merged 7 commits into from
Sep 8, 2024

Conversation

hanson-hschang
Copy link
Collaborator

Add feature #23.

  • set up camera location
  • set up camera look at location
  • set up transparent film background

@hanson-hschang hanson-hschang self-assigned this Sep 7, 2024
@skim0119
Copy link
Collaborator

skim0119 commented Sep 8, 2024

@hanson-hschang Could you add simple example script?

@hanson-hschang
Copy link
Collaborator Author

hanson-hschang commented Sep 8, 2024 •
edited
Loading

@skim0119 I added one example showing the camera movement.

camera_movement.mov

@hanson-hschang
Copy link
Collaborator Author

bsr.select_camera() defined in macros.py is changed to bsr.camera_manager.select()

skim0119
skim0119 approved these changes Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skim0119 skim0119 merged commit 96190a1 into main Sep 8, 2024
1 check passed
@skim0119 skim0119 deleted the feat/camera branch September 8, 2024 23:10
@hanson-hschang hanson-hschang mentioned this pull request Sep 9, 2024
Closed
@hanson-hschang hanson-hschang added the enhancement New feature or request label Sep 9, 2024
@hanson-hschang hanson-hschang linked an issue Sep 9, 2024 that may be closed by this pull request
Set up camera #23
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skim0119 skim0119 skim0119 approved these changes

Assignees

@hanson-hschang hanson-hschang

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up camera
2 participants
@hanson-hschang @skim0119