Fix installer's handling of duplicate directory paths #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Instead of having a separate
priority_dict, this now sorts all files to be installed into anOrderedDictwhich doesn't overwrite based on the destination path, but simply provides the correct order to copy paths so that higher priority files overwrite lower priority files while directories can get merged (depending on which tool is used to copy).This introduces a slight inefficiency insofar as duplicate files will get returned twice and, without further parsing, might be copied over each other, but the installer cannot know for certain if a path is a file or a folder.