add 4ColorsCard usecase #99

ChanWu77 · 2023-09-29T10:00:42Z

我在GameTest補上4種不同顏色卡的測試案例:
1.GREEN:麵包店
2.BLUE森林
3.PURPLE體育館
4.RED家庭餐廳
問題:紅色卡牌家庭餐廳(點數9~10)的測試不知道要怎麼寫成模擬兩顆假骰子一起骰，Mockito的部分還在想要怎麼寫

shmily7829

Review done.

src/test/java/domain/GameTest.java

shmily7829 · 2023-10-01T13:46:12Z

src/test/java/domain/GameTest.java

+        game.rollDice(playerB.getId(), 1);
+
+        // then
+        int bakerySize = handCard.getEstablishments(Bakery.class).size();


這裡不應該計算 bakerySize，而是手牌中 bakery 數量可獲得的金額，建議可改成 totalBakeryBonuses

shmily7829 · 2023-10-01T13:55:01Z

src/test/java/domain/GameTest.java

+        assertThat(playerB.getTotalCoins()).isEqualTo(2);
+        assertThat(game.getBank().getTotalCoin()).isEqualTo(originalBankCoins - bakerySize);


isEqualTo(2) 改為 isEqualTo(totalBakeryBonuses)

bakerySize 改為 totalBakeryBonuses

shmily7829 · 2023-10-01T14:04:27Z

src/test/java/domain/GameTest.java

+            當A骰子擲出點數為5時,
+            B可以從銀行得到2元，C可以從銀行得到1元
+            """)
+    void BLUE5_當B有2張森林B得到2元_當C有1張森林C得到1元() {


function name buleCardForestTest

shmily7829 · 2023-10-01T14:28:00Z

src/test/java/domain/GameTest.java

+        int point1 = dice1.throwDice();
+        int point2 = dice2.throwDice();


可以移除

…fourColorUsecases # Conflicts: # src/test/java/domain/GameTest.java

shmily7829

Review done.

shmily7829 · 2023-10-17T16:17:52Z

src/test/java/domain/GameTest.java

+        HandCard handCard = new HandCard();
+        handCard.addHandCard(new Bakery());
+        handCard.addHandCard(new Bakery());
+        Player playerB = Player.builder().id("B01").name("B").coins(0).handCard(handCard).build();


建立 PlayerA、B、C 物件可以抽成屬性，在 @beforeach 內賦值。
如果有測試案例用到 Player 就直接取用這些屬性。
整個檔案出現類似的程式碼都套用這個規則。

private Player playerA; @BeforeEach void setup() { playerA = Player.builder() .id("A01") .name("A") .build(); }

在各自的測試方法內呼叫 addCardToHandCard() 加入 handCard

shmily7829 · 2023-10-17T16:21:13Z

src/test/java/domain/GameTest.java

+        var originalBankCoins = game.getBank().getTotalCoin();
+
+        // when
+        Mockito.when(dice.throwDice()).thenReturn(2);


放在 mock 骰子物件下方。
這不是 when 的程式碼，而是 given 模擬的資料。
整個檔案出現類似的程式碼都套用這個規則

shmily7829 · 2023-10-17T16:30:17Z

src/test/java/domain/GameTest.java

+
+        // then
+        int totalBakeryBonuses = handCard.getEstablishments(Bakery.class).size();
+        assertThat(playerB.getTotalCoins()).isEqualTo(2);


isEqualTo(2)的 2 命名為具有領域意義的名稱，會更好理解

assertThat(playerB.getTotalCoins()).isEqualTo(totalBakeryBonuses);

整個檔案內的 assertion 都套用此規則

調整DisplayName說明清楚

shmily7829 · 2023-10-17T16:42:36Z

src/test/java/domain/GameTest.java

+        playerC.payCoin(2);
+        playerB.payCoin(2);
+        playerA.gainCoin(4);


nit,
體育館的發動效果沒有在 takeAllPlayersEffect() 裡面是正常的嗎?

已新增takeEffectPurple方法

shmily7829 · 2023-10-17T16:45:51Z

src/test/java/domain/GameTest.java

+            當玩家B有2張森林
+            當玩家C有1張森林


nit
測試 PlayerA 體育館的效果，PlayerB、C 可以不用有手牌也可以測試體育館效果。

shmily7829 · 2023-10-17T16:48:15Z

src/test/java/domain/GameTest.java

+
+    @Test
+    @DisplayName("""
+            當玩家A有2張麵包店跟火車站，且輪到A擲骰子


nit,
PlayerA 可以不用有手牌，也可以測試家庭餐廳的效果

shmily7829 · 2023-10-17T16:51:57Z

src/test/java/domain/GameTest.java

+
+        Player playerA = Player.builder().id("A01").name("A").coins(10).handCard(handCardA).build();
+        Landmark trainStation = playerA.getLandMark("火車站");
+        playerA.flipLandMark(trainStation, bank);


應該要在 Game new 出來之後火車站才能翻牌，並且需要使用 Game 物件裡面的 bank

shmily7829 · 2023-10-17T16:58:54Z

src/test/java/domain/GameTest.java

+        assertThat(playerA.getTotalCoins()).isEqualTo(4);
+        assertThat(playerB.getTotalCoins()).isEqualTo(2);


PlayerA 的 4 元和 PlayerB 的 2 元如何得出的?

shmily7829 · 2023-10-17T17:25:46Z

src/test/java/domain/GameTest.java

+        HandCard handCard = new HandCard();
+        handCard.addHandCard(new Bakery());
+        handCard.addHandCard(new Bakery());
+        Player playerB = Player.builder().id("B01").name("B").coins(0).handCard(handCard).build();


整個檔案中有用到的 Player 物件可以抽成屬性，並在 @Beforecach 內賦值
測試方法中有用到 Player 時可以直接調用屬性，不必重新 new 物件

private Player playerA; @BeforeEach void setup() { playerA = Player.builder() .id("A01") .name("A") .build(); }

shmily7829 · 2023-10-17T17:29:22Z

src/test/java/domain/GameTest.java

+        var originalBankCoins = game.getBank().getTotalCoin();
+
+        // when
+        Mockito.when(dice.throwDice()).thenReturn(2);


when 要寫的是測試的動作，
Mockito.when(dice.throwDice()).thenReturn(2);
是在 given 的時候建立模擬丟骰子的資料

add 4ColorsCard usecase

1201a5a

ChanWu77 requested review from shmily7829 and keytsai September 29, 2023 10:00

shmily7829 requested changes Oct 1, 2023

View reviewed changes

shmily7829 changed the base branch from main to develop October 4, 2023 13:44

cindy.hcy and others added 5 commits October 13, 2023 14:14

adjust functionName & redCardForestTest:playerA flipped Trainstation

a7da8c4

add 4ColorsCard usecase

9a936f4

adjust functionName & redCardForestTest:playerA flipped Trainstation

951637f

adjust Game isTwoDices into boolean value

3e924c2

Merge remote-tracking branch 'origin/add-fourColorUsecases' into add-…

65f1c58

…fourColorUsecases # Conflicts: # src/test/java/domain/GameTest.java

shmily7829 requested changes Oct 17, 2023

View reviewed changes

add four colors card usecases

16bf948

ChanWu77 requested a review from shmily7829 November 1, 2023 11:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add 4ColorsCard usecase #99

add 4ColorsCard usecase #99

ChanWu77 commented Sep 29, 2023

shmily7829 left a comment

shmily7829 Oct 1, 2023

shmily7829 Oct 1, 2023

shmily7829 Oct 1, 2023

shmily7829 Oct 1, 2023

shmily7829 left a comment

shmily7829 Oct 17, 2023

shmily7829 Oct 17, 2023

shmily7829 Oct 17, 2023

ChanWu77 Nov 1, 2023

shmily7829 Oct 17, 2023

ChanWu77 Nov 1, 2023

shmily7829 Oct 17, 2023

shmily7829 Oct 17, 2023

shmily7829 Oct 17, 2023 •

edited

Loading

shmily7829 Oct 17, 2023

shmily7829 Oct 17, 2023

shmily7829 Oct 17, 2023

		assertThat(playerB.getTotalCoins()).isEqualTo(2);
		assertThat(game.getBank().getTotalCoin()).isEqualTo(originalBankCoins - bakerySize);

		int point1 = dice1.throwDice();
		int point2 = dice2.throwDice();

		assertThat(playerA.getTotalCoins()).isEqualTo(4);
		assertThat(playerB.getTotalCoins()).isEqualTo(2);

add 4ColorsCard usecase #99

Are you sure you want to change the base?

add 4ColorsCard usecase #99

Conversation

ChanWu77 commented Sep 29, 2023

shmily7829 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shmily7829 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shmily7829 Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shmily7829 Oct 17, 2023 •

edited

Loading