feat(Landmark): Change CardSide attribute to flipped (boolean) #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Change CardSide attribute to flipped (boolean) 2. Rename from ownedEstablishment to establishments 3. Rename from ownedLandmark to landmarks
shmily7829
reviewed
Jul 11, 2023
src/test/java/domain/PlayerTest.java
Outdated
| @@ -56,15 +56,15 @@ void flipBackLandMark() { | |||
|
|
|||
| //then | |||
| assertThat(player.getTotalCoin()).isEqualTo(originalBalanceOfPlayer - 16); | |||
| assertThat(player.getOwnedLandmark().get(2).getCardSide()).isEqualTo(Landmark.CardSide.FRONT); | |||
| assertThat(player.getLandmarks().get(2).isFlipped()).isTrue(); | |||
There was a problem hiding this comment.
可以用 assertTure，並在getLandMarks方法加order參數
assertTrue(player.getLandmarks(2).isFlipped());
src/test/java/domain/PlayerTest.java
Outdated
| } | ||
|
|
||
| @Test | ||
| void flipFrontLandMark() { | ||
| //given 玩家有正面的主題樂園 | ||
| var originalBalanceOfPlayer = player.getTotalCoin(); | ||
| var amusementPark = new AmusementPark(); | ||
| player.getOwnedLandmark().get(2).setCardSide(Landmark.CardSide.FRONT); | ||
| player.getLandmarks().get(2).setFlipped(true); |
There was a problem hiding this comment.
ditto
getLandmarks(2)
Comment on lines
18
to
20
| var cropCardCount = (int) getOwner().getEstablishments().stream() | ||
| .filter(establishment -> establishment.getCardType().equals(CardType.CROP)) | ||
| .count(); |
There was a problem hiding this comment.
這段看能不能把篩選邏輯封裝在 getEstablishments
getOwner().getEstablishments(CardType.CROP)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#81
ownedEstablishment重新命名為establishmentsownedLandmark重新命名為landmarks