Make BlockGrave use the same logic as TileEntityGrave to determine player name #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlockGrave#getPlayerRelativeBlockHardness now uses EntityPlayer#getGameProfile#getName instead of EntityPlayer#getDisplayName. The latter may change if the player has a "nickname" (see: FTB Utilities), while the former should never change. Signed-off-by: unilock <[email protected]>
OneEyeMaker
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
BlockGrave#getPlayerRelativeBlockHardnessuseEntityPlayer#getGameProfile#getNameinstead ofEntityPlayer#getDisplayNameto determine the player's name, and compare it with that stored in the gravestone tile entity.This fixes incompatibilities with mods that change the player's
displayname, i.e. FTB Utilities with its "nicknames" function. Thedisplaynameof a player is much more susceptible to change than their profile's username.