fix informational constraint handling and make ssp-all valid correct

features/steps/fedramp_extensions_steps.ts

@@ -314,8 +314,10 @@ async function checkConstraints(
       }
 
       const kinds = constraintResults.map((c) => {
-        if(c.level==='warning'||c.kind==='informational'){
+        if(c.level==='warning'){
           return 'fail'
+        }else if(c.kind==='informational'){
+            return 'pass'
         }else{
           return c.kind
       }});

src/scripts/dev-constraint.js

@@ -115,10 +115,10 @@ function analyzeTestFiles() {
                     testResults[constraintId] = { pass: null, fail: null };
                 }
 
-                if (result === 'pass' || file.toUpperCase().includes('PASS')) {
+                if (result === 'pass' ||result ==='informational'|| file.toUpperCase().includes('PASS')) {
                     testResults[constraintId].pass = file;
                     testResults[constraintId].pass_file = filePath.split("/").pop();                
-                } else if (result === 'fail' ||result ==='informational'|| file.toUpperCase().includes('FAIL')) {
+                } else if (result === 'fail' || file.toUpperCase().includes('FAIL')) {
                     testResults[constraintId].fail = file;
                     testResults[constraintId].fail_file = filePath.split("/").pop();                
                 }

src/validations/constraints/content/ssp-all-VALID.xml

@@ -336,5 +336,54 @@
      <p>May use <code>rlink</code> with a relative path, or embedded as <code>base64</code>.</p>
   </remarks>
 </resource>
+
+
+<resource uuid="d2eb3c18-6754-4e3a-a933-03d289e3fad5">
+  <title>Authorization Boundary</title>
+  <description>
+     <p>Authorization Boundary Diagram</p>
+  </description>
+  <prop ns="https://fedramp.gov/ns/oscal" name="type" value="plan"/>
+  <prop name="published" value="2023-01-01T00:00:00Z"/>
+  <prop name="version" value="Document Version"/>
+  <rlink href="./documents/AuthBoundary.docx" media-type="application/msword"/>
+  <base64 filename="AuthBoundary.docx" media-type="application/msword">00000000</base64>
+  <remarks>
+     <p>May use <code>rlink</code> with a relative path, or embedded as <code>base64</code>.</p>
+  </remarks>
+</resource>
+
+<resource uuid="61081e81-850b-43c1-bf43-1ecbddcb9e7f">
+  <title>Network Architecture</title>
+  <description>
+     <p>Network Architecture Diagram</p>
+  </description>
+  <prop ns="https://fedramp.gov/ns/oscal" name="type" value="plan"/>
+  <prop name="published" value="2023-01-01T00:00:00Z"/>
+  <prop name="version" value="Document Version"/>
+  <rlink href="./documents/NetworkArchitecture.docx" media-type="application/msword"/>
+  <base64 filename="NetworkArchitecture.docx" media-type="application/msword">00000000</base64>
+  <remarks>
+     <p>May use <code>rlink</code> with a relative path, or embedded as <code>base64</code>.</p>
+  </remarks>
+</resource>
+
+<resource uuid="ac5d7535-f3b8-45d3-bf3b-735c82c64547">
+  <title>Data Flow</title>
+  <description>
+     <p>Data flow Diagram</p>
+  </description>
+  <prop ns="https://fedramp.gov/ns/oscal" name="type" value="plan"/>
+  <prop name="published" value="2023-01-01T00:00:00Z"/>
+  <prop name="version" value="Document Version"/>
+  <rlink href="./documents/Dataflo.docx" media-type="application/msword"/>
+  <base64 filename="Dataflow.docx" media-type="application/msword">00000000</base64>
+  <remarks>
+     <p>May use <code>rlink</code> with a relative path, or embedded as <code>base64</code>.</p>
+  </remarks>
+</resource>
+
+
+
   </back-matter>
 </system-security-plan>

src/validations/constraints/fedramp-external-constraints.xml

@@ -62,13 +62,13 @@
             <expect id="categorization-has-information-type-id" target="system-characteristics/system-information/information-type/categorization" test="information-type-id" level="ERROR">
                 <message>A FedRAMP SSP information type categorization must have at least one information type identifier.</message>
             </expect>
-            <expect id="has-identity-assurance-level" target="system-characteristics" test="prop[@name eq 'identity-assurance-level']" level="INFORMATIONAL">
+            <expect id="has-identity-assurance-level" target="system-characteristics" test="not(prop[@name eq 'identity-assurance-level'])" level="INFORMATIONAL">
                 <message>This FedRAMP SSP does define its NIST SP 800-63 identity assurance level (IAL).</message>
             </expect>
-            <expect id="has-authenticator-assurance-level" target="system-characteristics" test="prop[@name eq 'authenticator-assurance-level']" level="INFORMATIONAL">
+            <expect id="has-authenticator-assurance-level" target="system-characteristics" test="not(prop[@name eq 'authenticator-assurance-level'])" level="INFORMATIONAL">
                 <message>This FedRAMP SSP does define its NIST SP 800-63 authenticator assurance level (AAL).</message>
             </expect>
-            <expect id="has-federation-assurance-level" target="system-characteristics" test="prop[@name eq 'federation-assurance-level']" level="INFORMATIONAL">
+            <expect id="has-federation-assurance-level" target="system-characteristics" test="not(prop[@name eq 'federation-assurance-level'])" level="INFORMATIONAL">
                 <message>This FedRAMP SSP does define its NIST SP 800-63 federation assurance level (FAL).</message>
             </expect>
             <expect id="has-authorization-boundary-diagram" target="system-characteristics/authorization-boundary" test="diagram" level="WARNING">

src/validations/constraints/unit-tests/has-authenticator-assurance-level-FAIL.yaml

@@ -4,4 +4,4 @@ test-case:
   content: ../content/ssp-has-authenticator-assurance-level-INVALID.xml
   expectations:
     - constraint-id: has-authenticator-assurance-level
-      result: fail
+      pass_count: 0

src/validations/constraints/unit-tests/has-federation-assurance-level-FAIL.yaml

@@ -4,4 +4,4 @@ test-case:
   content: ../content/ssp-has-federation-assurance-level-INVALID.xml
   expectations:
     - constraint-id: has-federation-assurance-level
-      result: fail
+      pass_count: 0

src/validations/constraints/unit-tests/has-identity-assurance-level-FAIL.yaml

@@ -4,4 +4,4 @@ test-case:
   content: ../content/ssp-has-identity-assurance-level-INVALID.xml
   expectations:
     - constraint-id: has-identity-assurance-level
-      result: fail
+      pass_count: 0