Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce user constraints #743

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

wandmagic
Copy link
Collaborator

Committer Notes

Introduce constraints on the user object

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@aj-stein-gsa
Copy link
Contributor

I wil review this, but you do want me as assignee, but a review (I am in the fedramp-admins groups FYI). I am just always in a state of being perpetually behind! 😆

@aj-stein-gsa aj-stein-gsa removed their assignment Oct 3, 2024
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wandmagic should these constraints be updated w/ help-text and help-urls per ADR 9?

@wandmagic
Copy link
Collaborator Author

@wandmagic should these constraints be updated w/ help-text and help-urls per ADR 9?

Added help props and improved messages to include violating UUID

kindly let me know if the URI's i've chosen are appropriate

Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, just asking to use the URLs for now. help-text and help-markdown can come later.

@wandmagic
Copy link
Collaborator Author

Looks good so far, just asking to use the URLs for now. help-text and help-markdown can come later.

ok should be in there now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants