Skip to content

Commit

Permalink
only need the help uri
Browse files Browse the repository at this point in the history
  • Loading branch information
wandmagic committed Oct 4, 2024
1 parent 02dccfb commit 969e570
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 12 deletions.
2 changes: 1 addition & 1 deletion features/fedramp_extensions.feature
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ Scenario Outline: Ensuring full test coverage for "<constraint_id>"
Given I have loaded all Metaschema extensions documents
And I have added all documents to a single Document model
Then I should have both FAIL and PASS tests for constraint ID "<constraint_id>"
Then I should have three help props for constraint ID "<constraint_id>"
Then I should have help url prop for constraint ID "<constraint_id>"
Examples:
| constraint_id |
#BEGIN_DYNAMIC_CONSTRAINT_IDS
Expand Down
13 changes: 2 additions & 11 deletions features/steps/fedramp_extensions_steps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@ Given("I have added all documents to a single Document model", function () {
console.log("All documents have been added to a single Document model");
});

Then("I should have three help props for constraint ID {string}", function (constraintId) {
Then("I should have help url prop for constraint ID {string}", function (constraintId) {
const constraintRule = metaschemaDom.window.document.querySelector(`[id="${constraintId}"]`);

if (!constraintRule) {
Expand All @@ -695,16 +695,7 @@ Then("I should have three help props for constraint ID {string}", function (cons
{
namespace: "https://docs.oasis-open.org/sarif/sarif/v2.1.0",
name: "help-url"
},
{
namespace: "https://docs.oasis-open.org/sarif/sarif/v2.1.0",
name: "help-text"
},
{
namespace: "https://docs.oasis-open.org/sarif/sarif/v2.1.0",
name: "help-markdown"
}
];
} ];

const missingProps = requiredProps.filter(prop =>
!constraintRule.querySelector(`prop[ns="${prop.namespace}"][name="${prop.name}"]`)
Expand Down

0 comments on commit 969e570

Please sign in to comment.