Fixed and cleaned the swagger spec. [@JustSamuel] #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: justsamuel <[email protected]>
Signed-off-by: justsamuel <[email protected]>
Signed-off-by: justsamuel <[email protected]>
* adding nfc authenticator * fix module not exist error * nfc update and login working * remove unnecessary duplicate statement * Updating casing to be consistent with project * added authentication test case * added user-controller update nfc tests * test added for notexisting nfcCode * Revert "Merge branch 'feature/nfc' into develop" This reverts commit a11f85ad28d5ab617fa2d99b254c6eccd8b02ea4. * Revert "Revert "Merge branch 'feature/nfc' into develop"" This reverts commit 086f0298e1a3f614e2c526fbd0915777c07d86c6. * adding rule that nfcCode may not be empty to the update request spec and lintfix * added restriction to nfc code to be unique * added test for updating nfc * added delete function for nfc * creating tests for delete * improved test coverage * Do not log nfc code but only length on attempt
* Update dependencies * Bump node version from 16 to 18 * GitHub action to node18 node:18 is pulled on github01 and github02 runners already Co-authored-by: Roy Kakkenberg <[email protected]> --------- Co-authored-by: rinkp <[email protected]>
* create borrelkaartgroup with users * Update BorrelkaartGroup * Finish BorrelkaartGroup, initial tests * Add await check to esLint * Fix some tests * Fix incorrect merge * Correctly await everything, fix test cases * BorrelkaartGroups update * Fixed Signed-off-by: justsamuel <[email protected]> * Fix borrelkaartgroup get * Fix invoice problems * fix build error * Test cases * remove console debug * Fix some test cases & performed lint fix on async/await * Fix borrelkaartgroup test suite failing * Fix failing test cases * Fix naming (primarily saldo -> balance) * Fix refactor error --------- Signed-off-by: justsamuel <[email protected]> Co-authored-by: Bram Wieringa <[email protected]> Co-authored-by: justsamuel <[email protected]>
* Add more query parameters to getBalances function * Add endpoint query options to GET all balances * Add pagination to balance response
…. (#34) As the strict type definitions do not allow booleans for the 'pool' property, we cannot parse a boolean value from env. Should never hurt to enable it. Co-authored-by: samuel <[email protected]>
* first step * add key to authentication-controller * implement key to user controller * return the propper response and no key logging * add userId field to key login * make key deletion * adding unit test for correct response status * randomly generate keys * Typo's * fix merge request comments * fix two merge requests also removed a id leak for the pin login also update test for it * adding tests for validation for returned object --------- Co-authored-by: JorisParee <[email protected]>
rinkp
force-pushed
the
bugfix/swagger-spec
branch
from
0b9550b
to
1de6364
Compare
# Conflicts: # src/controller/borrelkaart-group-controller.ts # src/controller/response/balance-response.ts # src/controller/response/borrelkaart-group-response.ts # src/controller/root-controller.ts # src/entity/authenticator/nfc-authenticator.ts
* Fixed Transaction Mapping and Sellers bugs (#38) Fixed two bugs: - Bug where credit invoice entries contained products from SubTransactions with different sellers - Bug where transaction report reported products being sold from subTransactions from different sellers. * Merged develop into main (#37) * Feature/nfc (#28) * adding nfc authenticator * fix module not exist error * nfc update and login working * remove unnecessary duplicate statement * Updating casing to be consistent with project * added authentication test case * added user-controller update nfc tests * test added for notexisting nfcCode * Revert "Merge branch 'feature/nfc' into develop" This reverts commit a11f85ad28d5ab617fa2d99b254c6eccd8b02ea4. * Revert "Revert "Merge branch 'feature/nfc' into develop"" This reverts commit 086f0298e1a3f614e2c526fbd0915777c07d86c6. * adding rule that nfcCode may not be empty to the update request spec and lintfix * added restriction to nfc code to be unique * added test for updating nfc * added delete function for nfc * creating tests for delete * improved test coverage * Do not log nfc code but only length on attempt * Feature/update dependencies (#29) * Update dependencies * Bump node version from 16 to 18 * GitHub action to node18 node:18 is pulled on github01 and github02 runners already Co-authored-by: Roy Kakkenberg <[email protected]> --------- Co-authored-by: rinkp <[email protected]> * Feature/create borrelkaartgroup with users (#31) * create borrelkaartgroup with users * Update BorrelkaartGroup * Finish BorrelkaartGroup, initial tests * Add await check to esLint * Fix some tests * Fix incorrect merge * Correctly await everything, fix test cases * BorrelkaartGroups update * Fixed Signed-off-by: justsamuel <[email protected]> * Fix borrelkaartgroup get * Fix invoice problems * fix build error * Test cases * remove console debug * Fix some test cases & performed lint fix on async/await * Fix borrelkaartgroup test suite failing * Fix failing test cases * Fix naming (primarily saldo -> balance) * Fix refactor error --------- Signed-off-by: justsamuel <[email protected]> Co-authored-by: Bram Wieringa <[email protected]> Co-authored-by: justsamuel <[email protected]> * Feature/balance improvements (#33) * Add more query parameters to getBalances function * Add endpoint query options to GET all balances * Add pagination to balance response * Improve readme and .env-example (#30) * Add searching on user name (#35) * Enable pooling by default and read max connections from env variables. (#34) As the strict type definitions do not allow booleans for the 'pool' property, we cannot parse a boolean value from env. Should never hurt to enable it. Co-authored-by: samuel <[email protected]> * Apikey authenticate (#36) * first step * add key to authentication-controller * implement key to user controller * return the propper response and no key logging * add userId field to key login * make key deletion * adding unit test for correct response status * randomly generate keys * Typo's * fix merge request comments * fix two merge requests also removed a id leak for the pin login also update test for it * adding tests for validation for returned object --------- Co-authored-by: JorisParee <[email protected]> --------- Signed-off-by: justsamuel <[email protected]> Co-authored-by: JorisParee <[email protected]> Co-authored-by: Roy Kakkenberg <[email protected]> Co-authored-by: rinkp <[email protected]> Co-authored-by: Bram Wieringa <[email protected]> Co-authored-by: Kevin Jilissen <[email protected]> Co-authored-by: JorisParee <[email protected]> --------- Signed-off-by: justsamuel <[email protected]> Co-authored-by: JorisParee <[email protected]> Co-authored-by: Roy Kakkenberg <[email protected]> Co-authored-by: rinkp <[email protected]> Co-authored-by: Bram Wieringa <[email protected]> Co-authored-by: Kevin Jilissen <[email protected]> Co-authored-by: JorisParee <[email protected]>
# Conflicts: # package-lock.json # src/controller/authentication-controller.ts # src/controller/balance-controller.ts # src/controller/response/balance-response.ts # src/controller/user-controller.ts # test/unit/controller/user-controller.ts # test/unit/service/invoice-service.ts
|
fixes #40 |
CodeNamedRobin
requested changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: justsamuel [email protected]
https://gitlab.com/sudosos/sudosos-back-end/-/merge_requests/118