Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional nicknames to users #43

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Add optional nicknames to users #43

merged 4 commits into from
Aug 16, 2023

Conversation

Yoronex
Copy link
Member

@Yoronex Yoronex commented Aug 12, 2023

Title speaks for itself

@github-actions
Copy link

github-actions bot commented Aug 12, 2023 •
edited
Loading

SudoSOS Coverage Report

Commit: 60e49a5
Base: develop@93fcca3

Type Base This PR
Total Statements Coverage ?  88.62% (?)
Total Branches Coverage ?  84.23% (?)
Total Functions Coverage ?  90.24% (?)
Total Lines Coverage ?  88.35% (?)
Details (changed files)
FileStatementsBranchesFunctionsLines
Details (all files)
FileStatementsBranchesFunctionsLines
/src/index.ts 82.75% 50% 46.66% 82.51%
/src/authentication/token-handler.ts 100% 100% 100% 100%
/src/controller/authentication-controller.ts 88.82% 100% 96% 88.69%
/src/controller/authentication-secure-controller.ts 88.88% 100% 100% 88.88%
/src/controller/balance-controller.ts 78.04% 14.28% 100% 78.04%
/src/controller/banner-controller.ts 82.52% 95.45% 100% 82.52%
/src/controller/base-controller.ts 100% 100% 100% 100%
/src/controller/borrelkaart-group-controller.ts 79.41% 83.33% 100% 79.41%
/src/controller/container-controller.ts 85.13% 93.33% 100% 84.72%
/src/controller/debtor-controller.ts 83.54% 93.75% 100% 83.78%
/src/controller/invoice-controller.ts 80.72% 77.27% 100% 80.48%
/src/controller/payout-request-controller.ts 81.33% 92.85% 100% 81.33%
/src/controller/point-of-sale-controller.ts 69.87% 76.31% 83.33% 69.13%
/src/controller/product-category-controller.ts 82.45% 100% 100% 82.45%
/src/controller/product-controller.ts 84% 91.3% 100% 84.93%
/src/controller/rbac-controller.ts 88.23% 100% 100% 88.23%
/src/controller/root-controller.ts 85.71% 100% 100% 85.71%
/src/controller/simple-file-controller.ts 11.62% 0% 0% 11.62%
/src/controller/stripe-controller.ts 52.63% 100% 50% 52.63%
/src/controller/stripe-webhook-controller.ts 50% 100% 50% 50%
/src/controller/test-controller.ts 33.33% 100% 0% 33.33%
/src/controller/transaction-controller.ts 85.14% 96.96% 100% 84.69%
/src/controller/transfer-controller.ts 83.92% 94.73% 100% 83.33%
/src/controller/user-controller.ts 79.88% 91.07% 96.82% 79.92%
/src/controller/vat-group-controller.ts 87.8% 100% 100% 87.8%
/src/controller/request/validators/container-request-spec.ts 100% 100% 100% 100%
/src/controller/request/validators/duration-spec.ts 66.66% 50% 50% 64.28%
/src/controller/request/validators/general-validators.ts 88% 75% 75% 84.21%
/src/controller/request/validators/invoice-request-spec.ts 92.72% 81.81% 100% 97.72%
/src/controller/request/validators/point-of-sale-request-spec.ts 95% 75% 100% 94.11%
/src/controller/request/validators/product-request-spec.ts 90.32% 72.72% 100% 90%
/src/controller/request/validators/string-spec.ts 100% 100% 100% 100%
/src/controller/request/validators/update-local-request-spec.ts 100% 100% 100% 100%
/src/controller/request/validators/update-nfc-request-spec.ts 100% 100% 100% 100%
/src/controller/request/validators/update-pin-request-spec.ts 100% 100% 100% 100%
/src/controller/request/validators/user-request-spec.ts 86.95% 66.66% 85.71% 88.88%
/src/controller/request/validators/validation-errors.ts 88.05% 100% 63.63% 100%
/src/controller/response/dinero.ts 0% 0% 0% 0%
/src/database/database.ts 96.22% 100% 33.33% 98.07%
/src/entity/banner.ts 100% 100% 100% 100%
/src/entity/base-entity-without-id.ts 100% 100% 100% 100%
/src/entity/base-entity.ts 100% 100% 100% 100%
/src/entity/vat-group.ts 100% 100% 100% 100%
/src/entity/authenticator/authentication-method.ts 100% 100% 100% 100%
/src/entity/authenticator/ean-authenticator.ts 100% 100% 100% 100%
/src/entity/authenticator/hash-based-authentication-method.ts 100% 100% 100% 100%
/src/entity/authenticator/key-authenticator.ts 100% 100% 100% 100%
/src/entity/authenticator/ldap-authenticator.ts 100% 100% 100% 100%
/src/entity/authenticator/local-authenticator.ts 100% 100% 100% 100%
/src/entity/authenticator/member-authenticator.ts 100% 100% 100% 100%
/src/entity/authenticator/nfc-authenticator.ts 100% 100% 100% 100%
/src/entity/authenticator/pin-authenticator.ts 100% 100% 100% 100%
/src/entity/authenticator/reset-token.ts 100% 100% 100% 100%
/src/entity/container/base-container.ts 100% 100% 100% 100%
/src/entity/container/container-revision.ts 94.73% 100% 80% 92.3%
/src/entity/container/container.ts 100% 100% 100% 100%
/src/entity/container/updated-container.ts 100% 100% 100% 100%
/src/entity/deposit/stripe-deposit-status.ts 100% 100% 100% 100%
/src/entity/deposit/stripe-deposit.ts 100% 100% 100% 100%
/src/entity/file/banner-image.ts 100% 100% 100% 100%
/src/entity/file/base-file.ts 100% 100% 100% 100%
/src/entity/file/product-image.ts 100% 100% 100% 100%
/src/entity/fine/fine.ts 100% 100% 100% 100%
/src/entity/fine/fineHandoutEvent.ts 100% 100% 100% 100%
/src/entity/fine/userFineGroup.ts 100% 100% 100% 100%
/src/entity/invoices/invoice-entry.ts 100% 100% 100% 100%
/src/entity/invoices/invoice-status.ts 100% 100% 100% 100%
/src/entity/invoices/invoice.ts 100% 100% 100% 100%
/src/entity/point-of-sale/base-point-of-sale.ts 100% 100% 100% 100%
/src/entity/point-of-sale/point-of-sale-revision.ts 93.75% 100% 75% 90.9%
/src/entity/point-of-sale/point-of-sale.ts 100% 100% 100% 100%
/src/entity/point-of-sale/product-ordering.ts 100% 100% 100% 100%
/src/entity/point-of-sale/updated-point-of-sale.ts 100% 100% 100% 100%
/src/entity/product/base-product.ts 100% 100% 100% 100%
/src/entity/product/product-category.ts 100% 100% 100% 100%
/src/entity/product/product-revision.ts 91.66% 100% 50% 88.88%
/src/entity/product/product.ts 100% 100% 100% 100%
/src/entity/product/updated-product.ts 100% 100% 100% 100%
/src/entity/roles/assigned-role.ts 100% 100% 100% 100%
/src/entity/transactions/balance.ts 100% 100% 100% 100%
/src/entity/transactions/flagged-transaction.ts 100% 100% 100% 100%
/src/entity/transactions/payout-request-status.ts 100% 100% 100% 100%
/src/entity/transactions/payout-request.ts 100% 100% 100% 100%
/src/entity/transactions/sub-transaction-row.ts 100% 100% 100% 100%
/src/entity/transactions/sub-transaction.ts 100% 100% 100% 100%
/src/entity/transactions/transaction.ts 100% 100% 100% 100%
/src/entity/transactions/transfer.ts 100% 100% 100% 100%
/src/entity/transformer/dinero-transformer.ts 100% 83.33% 100% 100%
/src/entity/user/borrelkaart-group.ts 100% 100% 100% 100%
/src/entity/user/invoice-user.ts 100% 100% 100% 100%
/src/entity/user/local-user.ts 100% 100% 100% 100%
/src/entity/user/user-borrelkaart-group.ts 100% 100% 100% 100%
/src/entity/user/user.ts 100% 100% 100% 100%
/src/files/initialize.ts 100% 50% 100% 100%
/src/files/response.ts 28.57% 100% 0% 28.57%
/src/files/storage/disk-storage.ts 82.14% 83.33% 60% 82.14%
/src/files/storage/file-storage.ts 100% 100% 100% 100%
/src/files/storage/index.ts 100% 100% 50% 100%
/src/files/storage/locations.ts 100% 100% 100% 100%
/src/gewis/gewis.ts 72.88% 44.44% 40% 76.78%
/src/gewis/controller/gewis-authentication-controller.ts 87.03% 70% 100% 87.03%
/src/gewis/database/seed.ts 100% 100% 100% 100%
/src/gewis/entity/gewis-user.ts 100% 100% 100% 100%
/src/helpers/ad.ts 90.9% 100% 100% 90.9%
/src/helpers/bindings.ts 100% 100% 100% 100%
/src/helpers/database.ts 100% 100% 100% 100%
/src/helpers/ordering.ts 90.9% 83.33% 100% 90%
/src/helpers/pagination.ts 100% 85.71% 100% 100%
/src/helpers/query-filter.ts 100% 100% 100% 100%
/src/helpers/raw-body.ts 50% 100% 0% 50%
/src/helpers/revision-to-response.ts 94.73% 66.66% 100% 100%
/src/helpers/specification-validation.ts 97.29% 100% 88.88% 96.87%
/src/helpers/timestamps.ts 60% 50% 40% 60%
/src/helpers/token-helper.ts 100% 100% 100% 100%
/src/helpers/transaction-mapper.ts 95.89% 100% 88% 95.58%
/src/helpers/validators.ts 95.08% 90.9% 100% 93.75%
/src/mailer/index.ts 100% 100% 100% 100%
/src/mailer/mailer.ts 100% 100% 100% 100%
/src/mailer/transporter.ts 100% 100% 100% 100%
/src/mailer/templates/hello-world.ts 100% 100% 100% 100%
/src/mailer/templates/index.ts 100% 100% 100% 100%
/src/mailer/templates/mail-content.ts 100% 100% 100% 100%
/src/mailer/templates/mail-template.ts 100% 100% 100% 100%
/src/mailer/templates/password-reset.ts 78.94% 50% 57.14% 78.94%
/src/mailer/templates/signature.ts 100% 100% 100% 100%
/src/mailer/templates/user-got-fined.ts 78.57% 100% 57.14% 78.57%
/src/mailer/templates/welcome-to-sudosos.ts 82.35% 50% 57.14% 82.35%
/src/mailer/templates/welcome-with-reset.ts 82.35% 50% 57.14% 82.35%
/src/middleware/policy-middleware.ts 81.81% 100% 100% 81.81%
/src/middleware/request-validator-middleware.ts 100% 100% 100% 100%
/src/middleware/restriction-middleware.ts 93.75% 92.85% 75% 100%
/src/middleware/token-middleware.ts 100% 100% 100% 100%
/src/rbac/role-manager.ts 95% 87.5% 100% 98.03%
/src/service/ad-service.ts 85.86% 52.94% 90% 89.04%
/src/service/authentication-service.ts 89.65% 81.08% 86.95% 91.74%
/src/service/balance-service.ts 98.09% 91.8% 100% 97.87%
/src/service/banner-service.ts 95.23% 86.95% 100% 95.12%
/src/service/borrelkaart-group-service.ts 100% 93.1% 100% 100%
/src/service/container-service.ts 98.7% 88.52% 100% 100%
/src/service/debtor-service.ts 100% 95.83% 100% 100%
/src/service/file-service.ts 98.21% 81.81% 100% 98.18%
/src/service/invoice-service.ts 98.18% 91.66% 100% 99.35%
/src/service/payout-request-service.ts 100% 96.15% 100% 100%
/src/service/point-of-sale-service.ts 92.23% 68.18% 91.66% 93.81%
/src/service/product-category-service.ts 100% 100% 100% 100%
/src/service/product-service.ts 89.6% 73.61% 85.18% 90.43%
/src/service/rbac-service.ts 100% 100% 100% 100%
/src/service/stripe-service.ts 35.71% 10% 57.14% 35.84%
/src/service/transaction-service.ts 96.95% 86.53% 100% 96.66%
/src/service/transfer-service.ts 100% 95% 100% 100%
/src/service/user-service.ts 95.45% 73.33% 90% 97.5%
/src/service/vat-group-service.ts 98.64% 76.19% 92.85% 98.43%
/src/start/swagger.ts 86.66% 80% 66.66% 86.2%

CodeNamedRobin
CodeNamedRobin requested changes Aug 12, 2023
View reviewed changes
Copy link
Contributor

@CodeNamedRobin CodeNamedRobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only requested change is that I need to see a transaction for 2 kruidige tripel for Roy Kakkenberg in SudoSOS.

JustSamuel
JustSamuel requested changes Aug 13, 2023
View reviewed changes
Copy link
Contributor

@JustSamuel JustSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik mis wel dat je nu niet kan zoeken op nickname, wat wel imho een deel van het punt is? Iig moeten we het nog even hebben over hoe we zoeken aanpassen want nu zouden we dus nog meer zooi moeten toevoegen aan de search op user query. Ik ben nogsteeds van mening dat we het beste er van uit kunnen gaan dat we Mysql gebruiken en een fallback query maken voor als het niet zo blijkt te zijn.

JustSamuel
JustSamuel approved these changes Aug 13, 2023
View reviewed changes
Copy link
Contributor

@JustSamuel JustSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lftm after changes

JustSamuel
JustSamuel approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@JustSamuel JustSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mooi?

@Yoronex Yoronex merged commit 543b071 into develop Aug 16, 2023
4 checks passed
@Yoronex Yoronex deleted the feature/nicknames branch August 16, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeNamedRobin CodeNamedRobin CodeNamedRobin requested changes

@JustSamuel JustSamuel JustSamuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yoronex @JustSamuel @CodeNamedRobin