-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle ObjectGUID as Buffer correctly #332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mixing little endian and big endian should be considered a warcrime. https://joelitechlife.ca/2021/04/05/get-objectguid-of-microsoft-active-directory-using-ldapsearch/
JustSamuel
force-pushed
the
fix/ldap-objectguid-handling
branch
from
September 18, 2024 19:48
3244779
to
34ab16b
Compare
Note @Yoronex that this is quite a nifty migration, so this should only be done under supervision so that we can recover it if needed. |
JustSamuel
force-pushed
the
fix/ldap-objectguid-handling
branch
from
September 18, 2024 20:53
11c2675
to
4d4e365
Compare
JustSamuel
force-pushed
the
fix/ldap-objectguid-handling
branch
from
September 18, 2024 23:43
4d4e365
to
953190f
Compare
Yoronex
requested changes
Sep 19, 2024
JustSamuel
force-pushed
the
fix/ldap-objectguid-handling
branch
from
September 19, 2024 08:58
3523979
to
581cb1a
Compare
Yoronex
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mixing little endian and big endian should be considered a warcrime.
https://joelitechlife.ca/2021/04/05/get-objectguid-of-microsoft-active-directory-using-ldapsearch/
Related issues/external references
Types of changes