[API] Improve status reporting content/headers #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinkp
force-pushed
the
feat/apiinternalerroris500
branch
from
ab50ba1
to
c08633e
Compare
tomudding
approved these changes
Jul 24, 2024
github-actions bot
added a commit
that referenced
this pull request
Jul 24, 2024
rinkp: Merge pull request GH-425 from rinkp/feat/apiinternalerroris500 Reviewers: Tom Udding <[email protected]> Co-authored-by: rinkp <[email protected]>
rinkp
added a commit
to GEWIS/gewisdb-ts-client
that referenced
this pull request
Jul 24, 2024
In GEWIS/gewisdb#425, [openapi.yaml](https://github.com/GEWIS/gewisdb/pull/425/files#diff-d910ba2ef878f7db0223a966b81c8b3f3b65027bb39e4431bb05140171eece39) was changed. This commit updates the API spec to version 3.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we update the way normal and abnormal situations are reported on in the API. Authentication and authorization is handled separately from error reporting. We also distinguish between API routes and regular interactive routes for displaying models.
This also introduces a test endpoint for 404 and 500 errors.
Related issues/external references
Resolves GH-423, will now return a 500 instead of a 302 on internal server errors.
Types of changes
Client applications that rely on a 302 status code to detect failures may experience issues, API version was upgraded to major version 3 as a result.