New association year, new secretary

[tomudding]

Description

It is July 11 (GH-309), so it is time for another update to the renewal emails. Update the sender in renewal emails to Jens, the secretary for 2024-2025.

I am still against having the names hard-coded in the e-mails, but as previously discussed in GH-286 we do not have a better way of doing this (yet).

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation improvement (no changes to code)
• Other (please specify)

[rinkp]

GH-390 to the rescue?

In the long run that will require a frontend but in the meantime it can still be better to edit it in the database instead of in the code.

[tomudding]

GH-390 to the rescue?

In the long run that will require a frontend but in the meantime it can still be better to edit it in the database instead of in the code.

I have been thinking about this for a few weeks, and at first, I only saw new problems. However, this will work because of the existing exception handling:

gewisdb/module/Checker/src/Service/Renewal.php

Lines 52 to 60 in 4692ad9

	$renewalLink = $this->actionLinkMapper->createRenewalByMember($graduate);
	try {
	$this->sendRenewalEmail($renewalLink);
	} catch (Throwable $e) {
	$this->actionLinkMapper->remove($renewalLink);
	throw $e;
	}

I will modify this PR to move to the configuration service but will not implement a UI for it.

[tomudding]

The 'ready for review' button just disappeared, that is rather unfortunate

[tomudding]

Adjusted based on our earlier discussions of not wanting to hardcode anything. Moving it to the dynamic configuration was an option but still requires someone to make the appropriate changes at the right time; that is an assumption we should not want to make.

Further adjustments were made based on feedback from the board.