Fix membershipEndsOn not updating when making Member external
#421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original code was added in 0b26dfb to address an issue with the membership change, however, later in 9f75598 the `+ 2` / `+ 1` for the expiration were reverted to make all membership changes retroactive again. Unfortunately, the case for `external` was never changed to reflect this. As such, the `membershipEndsOn` was always in the past, while for `external` this is not allowed (should always be at the end of the current assocation year).
rinkp
approved these changes
Jul 6, 2024
There was a problem hiding this comment.
Yes, I think the external case is now treated correctly. I think the others behave as intended as well. Based on the transition matrix I could not think of situations which require other dates, so I retract my suggestion that we should offer the secretary a choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original code was added in 0b26dfb to address an issue with the membership change, however, later in 9f75598 the
+ 2/+ 1for the expiration were reverted to make all membership changes retroactive again. Unfortunately, the case forexternalwas never changed to reflect this. As such, themembershipEndsOnwas always in the past, while forexternalthis is not allowed (should always be at the end of the current assocation year).Related issues/external references
Fixes GH-420 and ABC-2407-095.
Types of changes