The gross check is missing for the q observations from the rawinsonde

[gmao-wgu]

Description

There is no gross check for the q observations from the rawinsonde

[rtodling]

I would expect this to come with an update to the benchmark numbers in ufo_tests.yaml ... I'd consider suspicious if the sondes numbers does change with this ... !?

[gmao-wgu]

It's odd that we were able to get matching numbers between GSI and JEDI without the gross check included. @asewnath what is your take on this?

[gmao-wgu]

I am still looking into it.

[Dooruk]

I ran a Tier1 test with this branch and ufo is indeed failing:
https://github.com/GEOS-ESM/swell/actions/runs/10947010213

Looks like it's a minor diff though, @gmao-wgu if you want to change the value to 116684:
FAILED passed == passedBenchmark evaluated as [116684] == [116687]

swell/src/swell/configuration/jedi/interfaces/geos_atmosphere/observations/ufo_tests.yaml

Lines 135 to 137 in dae29b4

	sondes:
	filter_test:
	passedBenchmark: 116687

[asewnath]

I ran a Tier1 test with this branch and ufo is indeed failing: https://github.com/GEOS-ESM/swell/actions/runs/10947010213

Looks like it's a minor diff though, @gmao-wgu if you want to change the value to 116684: FAILED passed == passedBenchmark evaluated as [116684] == [116687]

swell/src/swell/configuration/jedi/interfaces/geos_atmosphere/observations/ufo_tests.yaml

Lines 135 to 137 in dae29b4

	sondes:
	filter_test:
	passedBenchmark: 116687

Thanks for checking this @Dooruk!

[gmao-wgu]

This is still incomplete. I have not figured out how to set the lower and upper bounds for the q observation errors.

[Dooruk]

This is still incomplete. I have not figured out how to set the lower and upper bounds for the q observation errors.

Sounds good. I thought the UFO value was the final change required.

[rtodling]

I'm fine w/ this.

[Dooruk]

@gmao-wgu is this ready to go in? needs to be merged with develop

[gmao-wgu]

@Dooruk It is still a work in progress because the upper and lower bounds of the observation error are missing in the gross check.

[Dooruk]

@Dooruk It is still a work in progress because the upper and lower bounds of the observation error are missing in the gross check.

Sounds good, thanks