Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tclune/mapl3 wildcard support #2249

Merged
merged 11 commits into from
Jul 26, 2023
Merged

Feature/tclune/mapl3 wildcard support #2249

merged 11 commits into from
Jul 26, 2023

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Jul 21, 2023

Description

Added support for using wildcard in history via generic3g features.

Tested with unit tests. Not with model.

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@tclune
Initial changes for wildcard support.
7a0ae5b 
Logic now relies upon matching patterns amoung src and dst pts in
MatchConnection, but uses a very simple (trivial) regexp for now.
Next step is to wire in an existing regexp library to do a more
general comparison.
@tclune
Works for non-wildcard cases.
48ef0a1
@tclune
Saving for safety.
471ff89 
Wildcard tests still fail.  Some reasons for failure are understood,
but require nontrivial changes.
@tclune
Tests pass.
4048ccc 
Now to clean.
@tclune
Cleanup.
87de719 
Left one debug print in to remind about memory leak that needs to be
addressed.
@tclune tclune added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Skip Changelog 📈 MAPL3 MAPL 3 Related labels Jul 21, 2023
@tclune tclune requested a review from atrayano July 21, 2023 21:03
@tclune tclune requested review from a team as code owners July 21, 2023 21:03
atrayano
atrayano previously approved these changes Jul 24, 2023
View reviewed changes
@tclune
Workarounds for GFortran
11ca86e 
 - Incorrect reallocation on polymorphic assignment
 - Error when using ASSOCIATE instead of declaring local variables
@tclune
Merge branch 'rebase' into feature/tclune/mapl3-wildcard-support
5679d2a
@tclune tclune requested a review from atrayano July 26, 2023 12:27
atrayano
atrayano previously approved these changes Jul 26, 2023
View reviewed changes
tclune
tclune commented Jul 26, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
tclune
tclune commented Jul 26, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@mathomp4 mathomp4 merged commit d8b7382 into release/MAPL-v3 Jul 26, 2023
8 checks passed
@mathomp4 mathomp4 deleted the feature/tclune/mapl3-wildcard-support branch July 26, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

@atrayano atrayano atrayano left review comments

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tclune @mathomp4 @atrayano