-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tclune/mapl3 wildcard support #2249
Merged
mathomp4
merged 11 commits into
release/MAPL-v3
from
feature/tclune/mapl3-wildcard-support
Jul 26, 2023
Merged
Feature/tclune/mapl3 wildcard support #2249
mathomp4
merged 11 commits into
release/MAPL-v3
from
feature/tclune/mapl3-wildcard-support
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logic now relies upon matching patterns amoung src and dst pts in MatchConnection, but uses a very simple (trivial) regexp for now. Next step is to wire in an existing regexp library to do a more general comparison.
Wildcard tests still fail. Some reasons for failure are understood, but require nontrivial changes.
Now to clean.
tclune
added
🎁 New Feature
This is a new feature
0 Diff
The changes in this pull request have verified to be zero-diff with the target branch.
Skip Changelog
📈 MAPL3
MAPL 3 Related
labels
Jul 21, 2023
atrayano
reviewed
Jul 24, 2023
atrayano
previously approved these changes
Jul 24, 2023
- Incorrect reallocation on polymorphic assignment - Error when using ASSOCIATE instead of declaring local variables
atrayano
previously approved these changes
Jul 26, 2023
tclune
commented
Jul 26, 2023
mathomp4
approved these changes
Jul 26, 2023
tclune
commented
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0 Diff
The changes in this pull request have verified to be zero-diff with the target branch.
📈 MAPL3
MAPL 3 Related
🎁 New Feature
This is a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for using wildcard in history via generic3g features.
Tested with unit tests. Not with model.
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: