Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2244. Add print of regrid method to history init #2245

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

mathomp4
Copy link
Member

Description

Adds a print of the regrid method to the history initialization prints:

 Initializing Output Stream: geosgcm_prog
 ---------------------------
       Format: CFIO
         Mode: instantaneous
       Slices:          483
      Deflate:            1
    Frequency:        60000
     Ref_Date:     20000414
     Ref_Time:            0
     Duration:        60000
  Regrid Mthd: bilinear
  Output RSLV:           96          49
    XY-offset:            0   (DcPc: Dateline Center, Pole Center)
      Fields: PHIS SLP U V T PS H OMEGA QV QI QL RH O3 PLE
...

I added that Regrid Mthd line. The weird wording is because I wanted to keep the colons lined up. 😄

Related Issue

Closes #2244

Motivation and Context

Might as well print out what type of regridding is being used.

How Has This Been Tested?

I ran GEOS. Didn't crash, zero-diff, and the print appeared.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Jul 19, 2023
@mathomp4 mathomp4 self-assigned this Jul 19, 2023
@mathomp4 mathomp4 requested a review from a team as a code owner July 19, 2023 15:19
tclune
tclune previously approved these changes Jul 20, 2023
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were we not going to do a major refactoring, I'd push for pflogger.

@mathomp4 mathomp4 requested a review from bena-nasa July 20, 2023 16:41
@mathomp4 mathomp4 merged commit c678485 into develop Jul 20, 2023
8 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/2244-add-regrid-print branch July 20, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants