Feature/bmauer/extdatadriver delay #2237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tclune, thoughts on this, naming, style, etc...
Implemented a simple "mapl_sleep" function so as to avoid using the vendor "sleep", it takes a single integer argument in milliseconds (happy to change seconds etc...) and does what the name says, for that number of milliseconds. The extra bits are just in case this is called and crosses midnight.
Could not really thing of anything to add to this, not like there's any sort of error checking I can even think of to do here or even how one could add some sort of unit test for this since it is not as if there's something this returns one can check...
I did play overriding the intrinsic date_and_time so I could convince myself that indeed this would work when the system crosses midnight.
Wanted this so I could add the ability in ExtDataDriver.x to introduce a tilmestep latency for testing purposes and not use "sleep" given it is non-standard, which I also did in this branch
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: