Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bmauer/extdatadriver delay #2237

Merged
merged 5 commits into from
Jul 18, 2023

Conversation

bena-nasa
Copy link
Collaborator

@tclune, thoughts on this, naming, style, etc...

Implemented a simple "mapl_sleep" function so as to avoid using the vendor "sleep", it takes a single integer argument in milliseconds (happy to change seconds etc...) and does what the name says, for that number of milliseconds. The extra bits are just in case this is called and crosses midnight.

Could not really thing of anything to add to this, not like there's any sort of error checking I can even think of to do here or even how one could add some sort of unit test for this since it is not as if there's something this returns one can check...

I did play overriding the intrinsic date_and_time so I could convince myself that indeed this would work when the system crosses midnight.

Wanted this so I could add the ability in ExtDataDriver.x to introduce a tilmestep latency for testing purposes and not use "sleep" given it is non-standard, which I also did in this branch

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Jul 18, 2023
@bena-nasa bena-nasa requested review from a team as code owners July 18, 2023 15:33
shared/MAPL_Sleep.F90 Outdated Show resolved Hide resolved
@bena-nasa bena-nasa merged commit 6d3402f into develop Jul 18, 2023
8 checks passed
@bena-nasa bena-nasa deleted the feature/bmauer/extdatadriver_delay branch July 18, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants