Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geocachem ==> achem name changed #264

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

weiyuan-jiang
Copy link
Contributor

Address #263

@weiyuan-jiang weiyuan-jiang added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label May 27, 2022
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner May 27, 2022 15:07
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner May 27, 2022 15:14
@weiyuan-jiang
Copy link
Contributor Author

I have a concern. After this merge, the regrid.pl is not going to support the old name "geosachem" any more. Would that be OK ? @bena-nasa

@mathomp4
Copy link
Member

I have a concern. After this merge, the regrid.pl is not going to support the old name "geosachem" any more. Would that be OK ? @bena-nasa

@weiyuan-jiang Well, we can go with the "advice" we've always had: Use the regrid.pl from the model tag you want to run.

So, if you get a 10.22 GEOS, you'd expect it to look for achem_internal_rst. If it's an older one (GOCART1 days?) then regrid.pl would look for the "appropriate" geosachem_internal_rst file. I guess we sort of "broke" that in recent times.

If someone wants to use the latest regrid.pl with some old restarts, well, we might need to advise them to edit the perl script. I suppose you could put a comment in the code mentioning that this restart's name changed?

@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner June 8, 2022 17:08
@mathomp4
Copy link
Member

mathomp4 commented Jun 8, 2022

I pushed an update to try and fix the CI which is oddly failing.

Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake changes ok

@sdrabenh sdrabenh merged commit 64fbfad into main Jun 8, 2022
@sdrabenh sdrabenh deleted the feature/wjiang/geosachem_rst_name_changed branch June 8, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants