Fixes #55. ifdef out HDF4 readers #56
Draft
+3,611
−3,579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged. |
|
Throwing in a blocking label as we need one of the obs this turns off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The change seems more exciting than it is because my editor strips off trailing whitespace. To better see the change, use the "no whitespace" option: https://github.com/GEOS-ESM/GEOSldas_GridComp/pull/56/files?w=1
Closes #55
This PR adds
#if 0blocks around code that uses the HDF4 Fortran interface. As stated in #55, HDF4 (at the moment) no longer supports a Fortran interface (due to implementation bugs in the library)Per #55 (comment) by @gmao-rreichle, a solution is to just
#if 0the offending code so it remains, but isn't compiled (thus removing the need for HDF4).I think this is all that's needed, and it does build with
ifxbut I'm a bit scared as that was a lot of code I ifdef'd. I think in the end it turns off support for:and if those are still assimilated...
So, I'll keep it Draft until @biljanaorescanin can do a test.