-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add landice gridcomp #18
base: develop
Are you sure you want to change the base?
Conversation
…ldas into feature/wjiang/add_landice
GEOSldas_App/lenkf_j_template.py
Outdated
/bin/mv ${{rstf}}${{ENSID}}_internal_checkpoint $tmp_file | ||
/bin/rm -f $EXPDIR/input/restart/${{rstf}}${{ENSID}}_internal_rst | ||
/bin/ln -rs $tmp_file $EXPDIR/input/restart/${{rstf}}${{ENSID}}_internal_rst | ||
set rstfs = (${{MODEL}} 'landice') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weiyuan-jiang: "MODEL" here is the particular flavor of the land (Catchment) model. Now that we're integrating landice and lake, which include their own "model", I think it would be good to rename "MODEL" to "LANDMODEL" for clarity. Does this make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I have changed the name
@weiyuan-jiang: I just came across the following assumption in pre-processing: the *.til file must have all of the land tiles at the beginning. This has worked so far, but it is not a safe assumption (as noted in my comment from 2020). You are probably already aware of it in the context of the present PR, but I'm mentioning it here just in case.
|
PS: The exact same code appears again a couple of hundred lines later:
|
This PR is corresponding to the GEOSldas PR to add GEOSlake_GridComp