Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GEOSgcm_GridComp under Components in GEOSldas #765

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Apr 11, 2024

Currently, GEOSgcm_GridComp is cloned via mepo under GEOSldas_GridComp (which echoes how it was in in GEOSldas v17 and older). This PR moves GEOSgcm_GridComp under Components in GEOSldas. This makes its location consistent with GEOSgcm and GEOSadas.

Note that this PR requires a corresponding change in the GEOSldas_GridComp repo:

GEOS-ESM/GEOSldas_GridComp#27


Also, in this PR I've update components.yaml to point to the corresponding branch in GEOSldas_GridComp. This of course moves to develop and then a tag in the usual way.

Currently, GEOSgcm_GridComp is cloned via mepo under GEOSldas_GridComp (which echoes how it
was in in GEOSldas v17 and older). This PR moves GEOSgcm_GridComp under Components in GEOSldas. This
makes its location consistent with GEOSgcm and GEOSldas.

Note that this PR requires a corresponding change in the XXX repo:
@gmao-rreichle gmao-rreichle marked this pull request as ready for review April 11, 2024 19:07
@gmao-rreichle gmao-rreichle requested review from a team as code owners April 11, 2024 19:07
@gmao-rreichle gmao-rreichle merged commit 95b2b49 into develop Apr 11, 2024
5 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/mathomp4/move-gcmgc-ldas branch April 11, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants