Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create IMS.rc or JMS.rc directly on run_dir #740

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Mar 21, 2024

The present PR is a continuation of #733.
It is not safe when multi ldas_setup run at the same time and using the same IMS.rc or JMS.rc. This PR creates the files on the run directory.

@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner March 21, 2024 13:30
@gmao-rreichle
Copy link
Contributor

this again had the wrong MAPL. i just updated the branch at 9:57am

@biljanaorescanin
Copy link
Contributor

All nightly tests passed.

@gmao-rreichle
Copy link
Contributor

gmao-rreichle commented Mar 21, 2024

@weiyuan-jiang : Can you please clarify if the present PR (#740) is a correction of #733? That is, should #740 be considered a continuation of #733?
Or is #740 something that you just happened to think of and then out of convenience you added the present changes on the branch associated with #733? If so, #740 and #733 aren't really related.
Given the re-use of the branch name from #733, the introductory comment above is a bit unclear

[CORRECTED 22 March 2024: original comment mistakenly referred to #739 instead of #733.]

@weiyuan-jiang
Copy link
Contributor Author

weiyuan-jiang commented Mar 21, 2024

@gmao-rreichle , #739 and #740 are unrelated. This PR (#740) is continuation of PR #733 that was merged last night. I had some concern to create IMS.rc and JMS.rc on temporary directory. If multi ldas_setup are running, there would be conflict.

@gmao-rreichle gmao-rreichle merged commit 6ed3382 into develop Mar 21, 2024
7 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/699-use-tempfile branch March 25, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants