-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to MAPL v2.44.1 to fix "binary + bit shaving" bug #734
Conversation
Note: Labeled as non-zero-diff, but only because that's a guess. Maybe it is? |
With this PR adding instantaneous 6h collection to GLOBAL/model test doesn't affect the restart file. |
@gmao-rreichle @mathomp4 @weiyuan-jiang @bena-nasa After running nightly tests we do have 2 failed model run tests: Image PC Routine Line Source
/bin/rm: cannot remove 'strip': No such file or directory Here: |
Thanks, @biljanaorescanin, for running the tests. @bena-nasa: Does the error message reported by @biljanaorescanin above make any sense to you? |
It seems a bug. Above that line, a line if(i == -1) cycle should be added. @bena-nasa |
All nightly tests passed. |
@biljanaorescanin I've updated the PR with the new MAPL 2.44.1 release. |
This PR updates GEOSldas to MAPL v2.44.1 (see GEOS-ESM/MAPL#2658). This fixes a MAPL bug that was introduced in MAPL v2.8.6.
In MAPL v2.8.6 (used in GEOSldas v17.9.6), a bit-shaving option was added for MAPL binary output. Unfortunately, the bit shaving was done in place for binary, instantaneous output. Depending on the output variables, the bit shaving degraded the internal state (or model prognostic variables) and thereby adversely impacted the simulation and the checkpoint/restart files.
GEOSldas routinely uses MAPL binary output to write tile-space data, which are then converted to netcdf in post-processing using the GEOSldas utility
tile_bin2nc4.F90
. So the MAPL bug could impact GEOSldas simulations even when the final output files are nc4 format.The SMAP L4 ops system does bit-shaving in post-processing, so the L4_SM products are ok. Science runs using v17.9.6 to v17.13.1 and recent branches/tags are impacted depending on the HISTORY specs.