Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LDAS_App under GEOSldas_GridComp as GEOSldas_App #717

Closed
wants to merge 1 commit into from

Conversation

mathomp4
Copy link
Member

Draft PR to see what happens when Applications/LDAS_App is moved to Components/GEOSldas_GridComp/GEOSldas_App

@gmao-rreichle
Copy link
Contributor

@mathomp4 : Now that GEOSldas Release v18.0.0 is done, we can change the repo structure. My preference is to create only one "GridComp" repo in addition to a fixture repo, as in the present PR. That is, the "GridComp" repo should include the "App" dir.

The only branch that needs translating into the new repo structure is @weiyuan-jiang's branch feature/wjiang/add_landice, which is associated with #705. This branch still needs updating to the current "develop", but I'd prefer that @weiyuan-jiang does the update.

I assume the next step would be for you to put together the new repo structure and PR for real and create a new PR for the change.

Please let me know if you have any questions, thanks!

cc: @biljanaorescanin

@mathomp4
Copy link
Member Author

I'm going to re-do this PR again. The conflicts are just confusing enough I want to do it again carefully.

@mathomp4 mathomp4 closed this Mar 25, 2024
@mathomp4 mathomp4 deleted the feature/mathomp4/move-ldas-app branch March 25, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants