Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CEDS emissions for CO in achem (R21C) #278

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Update CEDS emissions for CO in achem (R21C) #278

merged 6 commits into from
Jul 25, 2024

Conversation

acollow
Copy link
Contributor

@acollow acollow commented Jul 22, 2024

This aligns the CO emissions used by achem to be consistent with the revised version of CEDS that is now being used by GOCART.

@acollow
This aligns the CO emissions used by achem to be consistent with the …
e0a6716 
…revised version of CEDS that is now being used by GOCART
@acollow acollow added Non 0-diff The changes in this pull request are non-zero-diff bugfix This fixes a bug labels Jul 22, 2024
@acollow acollow requested review from a team as code owners July 22, 2024 18:33
@mathomp4
Copy link
Member

Note: this might fail until #273 is in. Weirdly, I thought I had fixed up the CI here. The changelog says I did. Huh.

@mathomp4 mathomp4 mentioned this pull request Jul 22, 2024
Open
@acollow acollow changed the base branch from develop to R21C July 22, 2024 20:16
@mathomp4
Copy link
Member

I'm going to see if I can fix up the CI here.

Also, @acollow, you probably want to make a similar PR to develop here as well so @mmanyin can bring that in to match the updates in GOCART

@mathomp4 mathomp4 changed the title Update CEDS emissions for CO in achem Update CEDS emissions for CO in achem (R21C) Jul 23, 2024
@mathomp4 mathomp4 added 0 diff structural Structural changes to repository that are zero-diff and removed 0 diff structural Structural changes to repository that are zero-diff labels Jul 23, 2024
mmanyin
mmanyin approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@mmanyin mmanyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mmanyin mmanyin merged commit d967ba6 into R21C Jul 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmanyin mmanyin mmanyin approved these changes

@sdrabenh sdrabenh sdrabenh approved these changes

Assignees

@mathomp4 mathomp4

@elakkraoui elakkraoui

@sdrabenh sdrabenh

Labels
bugfix This fixes a bug Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@acollow @mathomp4 @mmanyin @sdrabenh @elakkraoui