Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates to group unpack and rats provider checks #269

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

christophkeller
Copy link
Collaborator

This PR brings in two small updates that I made in support of GEOS-Chem simulations at higher resolutions. These updates were cherry-picked from branch feature/cakelle2/gcc_rats_provider. This branch has a number of additional updates that don't need to go into develop. The two updates are:

  1. Add an optional verbose flag to routine Unpack_Chem_Groups (commit a558d09): If verbose is set to .false., it will stop printing all the N/Cl LOOP COUNT statements, which can clog up the logfile.
  2. Expand the logic of the RATS provider connectivities (commit 11522b8): This makes sure that RATS connectivities between two components are only established if that chemistry component is indeed selected as the RATS provider.

Christoph Keller added 2 commits December 8, 2023 12:16
@christophkeller christophkeller added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Dec 8, 2023
@christophkeller christophkeller requested review from a team as code owners December 8, 2023 17:33
@mmanyin
Copy link
Contributor

mmanyin commented Dec 12, 2023

@christophkeller Two small changes: in GEOS_ChemGridComp.F90 line 572 please change the provider to PCHEM.
Note that it doesn't cause a problem in the standard run because gas and aqueous chem are 'off' in ACHEM by default.

Also, please document these changes the CHANGELOG.md file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants