Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new BCS version #75

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Add new BCS version #75

merged 4 commits into from
Jun 10, 2024

Conversation

biljanaorescanin
Copy link
Contributor

@biljanaorescanin biljanaorescanin commented Jun 7, 2024 •
edited
Loading

New BCS version that includes bug fix over Argentina. This set is same as v11 with bug fix.

This PR is associated with 2 other PRs:
GEOS-ESM/GEOSgcm_GridComp#944
GEOS-ESM/GEOSgcm_App#616

@biljanaorescanin biljanaorescanin added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request labels Jun 7, 2024
@biljanaorescanin
Copy link
Contributor Author

PR is trivially zero diff to what was before since we are just adding new option.
PR was also tested for new option usage and that works. ( cases M2 to v12 and v12 to NL3) )

@biljanaorescanin biljanaorescanin marked this pull request as ready for review June 10, 2024 14:38
@biljanaorescanin biljanaorescanin requested review from a team as code owners June 10, 2024 14:38
@biljanaorescanin
Copy link
Contributor Author

@sdrabenh, @gmao-rreichle here is un-draft.
I think run fails are because run doesn't use develop but tag. We need develop for this to run.

gmao-rreichle
gmao-rreichle previously approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mathomp4
Copy link
Member

This seems to be the same CI issue as with GEOS-ESM/GEOSgcm_App#616

I am working on a fix now.

@mathomp4 mathomp4 requested a review from a team as a code owner June 10, 2024 17:35
@sdrabenh sdrabenh merged commit d172118 into main Jun 10, 2024
11 checks passed
@sdrabenh sdrabenh deleted the feature/borescan_v12_bcs branch June 10, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

@sdrabenh sdrabenh sdrabenh approved these changes

@gmao-rreichle gmao-rreichle gmao-rreichle left review comments

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@biljanaorescanin @mathomp4 @sdrabenh @gmao-rreichle