-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added command line feature for remap_restarts.py #19
Conversation
@biljanaorescanin Thanks for helping testing. Please save some examples so I can added to the test cases |
@weiyuan-jiang You should change to use the p.add_argument('--moist', help="Moist microphysics to use (Default: BACM)", type=str, default='BACM',
choices=['BACM','GFDL','MGB2']) and when I run
So argparse sort of automatically fills out the allowed choices which is nice and restricts it so you can't pass in unallowed options:
You can equivalently do something like: moist_choices = ['BACM','GFDL','MGB2']
p.add_argument('--moist', help="Moist microphysics to use (Default: BACM)", type=str, default='BACM',
choices=moist_choices) I'm never quite sure when's the right time to make a separate array. I suppose if you can use the array in more than one place... |
Great. |
The last commit addressed the issue #20 . Ben's scripts are slightly modified and plugged into this package. @bena-nasa I didn't take catchment's conversion because it is already converted during regridding. |
…est yaml files (remap_params.tpl, test/*.yaml)
… remap_command_line.py, remap_questions.py, remap_utils.py)
@sanAkel -- we have updated the Wiki page: https://github.com/GEOS-ESM/GEOS_Util/wiki/remap_restarts-package and ironed out a few more kinks (incl. making the package ready for NAS). Please take another look and see if this works for you. If so, please approve, so we can put this on @sdrabenh's desk. I'll defer to @sdrabenh on whether a notebook is needed, and we can always add it later. My preference would be to move this forward before a potential shutdown. Note also that we provide pre-configured test cases / examples in the ./test dir. Thanks! |
…S_Util into feature/wjiang/command_line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving after bug fix
@weiyuan-jiang we will need few more changes to run this on NAS. We did rsync BCS files but seems they use For everything else this PR was tested:
I couldn't find any issues. @sdrabenh let me know if you find something during your testing. |
Wiki looks reasonable for PR approval
@mathomp4 can you approve on behalf of cmake-team? @bena-nasa doesn't appear to have permissions |
Odd. He definitely should! I'll look into that next week |
Thanks @gmao-rreichle wiki looks self-sufficient. |
This PR added command line features. The interface also changed. To get help, please use
./remap_restarts.py -h
./remap_restarts.py config_file -h
./remap_restarts.py command_line -h