Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build time option for ocean model #57

Closed
wants to merge 2 commits into from

Conversation

sanAkel
Copy link
Collaborator

@sanAkel sanAkel commented Dec 2, 2023

This PR:

  • Introduces a build time option for ocean model; data ocean is always built.
  • Preserves answers.

Example:
If a user wants to build using MOM5 ocean model, in addition to these cmake options add: -DGEOS_OCEAN=MOM5; defaults are defined in a contingent PR. See ⬇️.

  • Has contingencies:
  1. GCM GC
  2. GCM App

@sanAkel sanAkel added 0 diff structural Structural changes to repository that are zero-diff Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs labels Dec 2, 2023
@sanAkel sanAkel self-assigned this Dec 2, 2023
Copy link

github-actions bot commented Dec 2, 2023

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff structural, Contingent - DNA

2 similar comments
Copy link

github-actions bot commented Dec 2, 2023

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff structural, Contingent - DNA

Copy link

github-actions bot commented Dec 2, 2023

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff structural, Contingent - DNA

Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff structural, Contingent - DNA

1 similar comment
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff structural, Contingent - DNA

@sanAkel
Copy link
Collaborator Author

sanAkel commented Feb 13, 2024

There is a dependency on mom6 library in src/Applications/@UMD_Etc/UMD_oletkf/CMakeLists.txt

esma_add_library (${this}
  SRCS ${SRCS}
  DEPENDENCIES **mom6** NetCDF::NetCDF_Fortran MPI::MPI_Fortran
  )

Because of above, one must always build GEOS with mom6, so build of mom5--only is not possible-- FYI: @mathomp4.

For now closing this PR, but noted for future.

@sanAkel sanAkel closed this Feb 13, 2024
@mathomp4
Copy link
Member

There is a dependency on mom6 library in src/Applications/@UMD_Etc/UMD_oletkf/CMakeLists.txt

esma_add_library (${this}
  SRCS ${SRCS}
  DEPENDENCIES **mom6** NetCDF::NetCDF_Fortran MPI::MPI_Fortran
  )

Because of above, one must always build GEOS with mom6, so build of mom5--only is not possible-- FYI: @mathomp4.

For now closing this PR, but noted for future.

Well, if MOM5 is selected, we could just not build UMD_oletkf? If it's needed for mom5 as well, then we'd have to explore more.

@sanAkel
Copy link
Collaborator Author

sanAkel commented Feb 13, 2024

There is a dependency on mom6 library in src/Applications/@UMD_Etc/UMD_oletkf/CMakeLists.txt

esma_add_library (${this}
  SRCS ${SRCS}
  DEPENDENCIES **mom6** NetCDF::NetCDF_Fortran MPI::MPI_Fortran
  )

Because of above, one must always build GEOS with mom6, so build of mom5--only is not possible-- FYI: @mathomp4.
For now closing this PR, but noted for future.

Well, if MOM5 is selected, we could just not build UMD_oletkf? If it's needed for mom5 as well, then we'd have to explore more.

That: not build UMD_oletkf can work, because truth is, nobody is running that UMD_oletkf.

@mathomp4 if you have the time, please do make that switch in UMD_oletkf to turn off its build with mom6. Thank you!

@mathomp4
Copy link
Member

@sanAkel So should I have UMD_oletkf build only with mom5 or only with mom6?

@sanAkel
Copy link
Collaborator Author

sanAkel commented Feb 15, 2024

@sanAkel So should I have UMD_oletkf build only with mom5 or only with mom6?

@mathomp4 We should not build it at all :) recall, I had a PR to remove it?

Anyway only mom5, that code will never work with mom6.

@sanAkel sanAkel deleted the feature/sanAkel/ocean-ice-buildOptions branch October 21, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff structural Structural changes to repository that are zero-diff Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants