Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer query and templates #1588

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

dbauszus-glx
Copy link
Member

@dbauszus-glx dbauszus-glx commented Oct 21, 2024

The geojson query template has been flagged as a layer query which requires a layer request parameter.

The getLayer method will attempt to retrieve a layer template from the templates if the layer param is not found in the locale.layers.

@dbauszus-glx dbauszus-glx self-assigned this Oct 21, 2024
@dbauszus-glx dbauszus-glx added Feature New feature requests or changes to the behaviour or look of existing application features. Security Ticket relates to either the authentication process, security headers, and or encryption. labels Oct 21, 2024
@dbauszus-glx dbauszus-glx linked an issue Oct 21, 2024 that may be closed by this pull request
@dbauszus-glx dbauszus-glx marked this pull request as ready for review October 21, 2024 12:31
@dbauszus-glx
Copy link
Member Author

I dismissed the security alert as not relevant. This should be addressed but not in this PR.

The issue is related to the params.user object which is assigned in the API method. User roles may be merged into a layer/template object and an error.message maybe returned from a failed query.

The security of the user object must be controlled in the API module which is yet to be tested and documented.

Message objects returned from failed requests should be escaped which may require a library. I will revise this in the relevant PR. #1309

Copy link

sonarcloud bot commented Oct 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature requests or changes to the behaviour or look of existing application features. Security Ticket relates to either the authentication process, security headers, and or encryption. v4.x.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layer queries and templates
2 participants