Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cloudinary provider module #1542

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dbauszus-glx
Copy link
Member

@dbauszus-glx dbauszus-glx commented Oct 8, 2024

The cloudinary provider module which requires the image/document payload to be passed through the xyz host has been removed.

The signer module has now been reviewed and documented.

The cloduinary signer module has now been reviewed and documented.

The module will not fail silently but return an error message.

The cloudinary entry is now using the cloudinary signer module.

The cloudinary entry is now reviewed and documented.

The cloudinary entry requires a cloudinary account. However, no third party module is required to sign requests, hence the cloudinary signer is included in the XYZ core and the cloudinary entry method is included in the mapp location entries.

@dbauszus-glx dbauszus-glx self-assigned this Oct 8, 2024
@dbauszus-glx dbauszus-glx added Code Issues related to the code structure and performance. Plugin Refers to an issue in a plugin or a feature which should be resolved in a plugin. Documentation Adding or updating documentation. labels Oct 8, 2024
@dbauszus-glx dbauszus-glx linked an issue Oct 8, 2024 that may be closed by this pull request
express.js Dismissed Show dismissed Hide dismissed
@dbauszus-glx dbauszus-glx marked this pull request as ready for review October 16, 2024 16:24
Copy link

sonarcloud bot commented Oct 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Issues related to the code structure and performance. Documentation Adding or updating documentation. Plugin Refers to an issue in a plugin or a feature which should be resolved in a plugin. v4.x.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloudinary provider and sign
3 participants