-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove cloudinary provider module #1542
Open
dbauszus-glx
wants to merge
7
commits into
GEOLYTIX:main
Choose a base branch
from
dbauszus-glx:cloudinary-entries-sign
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbauszus-glx
added
Code
Issues related to the code structure and performance.
Plugin
Refers to an issue in a plugin or a feature which should be resolved in a plugin.
Documentation
Adding or updating documentation.
labels
Oct 8, 2024
dbauszus-glx
requested review from
cityremade,
AlexanderGeere,
RobAndrewHurst and
simon-leech
October 16, 2024 16:20
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code
Issues related to the code structure and performance.
Documentation
Adding or updating documentation.
Plugin
Refers to an issue in a plugin or a feature which should be resolved in a plugin.
v4.x.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cloudinary provider module which requires the image/document payload to be passed through the xyz host has been removed.
The signer module has now been reviewed and documented.
The cloduinary signer module has now been reviewed and documented.
The module will not fail silently but return an error message.
The cloudinary entry is now using the cloudinary signer module.
The cloudinary entry is now reviewed and documented.
The cloudinary entry requires a cloudinary account. However, no third party module is required to sign requests, hence the cloudinary signer is included in the XYZ core and the cloudinary entry method is included in the mapp location entries.