add dataResourceExtension #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ension -> gaia-x specific Signed-off-by: jtdemer <[email protected]>
Signed-off-by: GitHub Action <[email protected]>
Signed-off-by: jtdemer <[email protected]>
…-AAD/ontology-management-base into dataResourceExtension
Signed-off-by: GitHub Action <[email protected]>
change subClassOf back to gx from dataResourceExtension Signed-off-by: Johannes Demer <[email protected]>
…nstance.json rename file Signed-off-by: Johannes Demer <[email protected]>
rename file Signed-off-by: Johannes Demer <[email protected]>
Signed-off-by: Johannes Demer <[email protected]>
lenasauermann
requested changes
Aug 29, 2024
general/general_ontology.ttl
Outdated
| @@ -14,7 +14,7 @@ general: a owl:Ontology ; | |||
| general:General a owl:Class ; | |||
| rdfs:label "Class definition for General" ; | |||
| rdfs:comment "General attributes for all assets"@en ; | |||
| rdfs:subClassOf gx:DataResource . | |||
| rdfs:subClassOf gx:DataResourceExtension . | |||
There was a problem hiding this comment.
dataResourceExtension:DataResourceExtension
| sh:description "Reference to media data"@en ; | ||
| sh:message "Validation of media failed!"@en ; | ||
| sh:name "media"@en ; | ||
| sh:node dataResourceExtension:UrlShape ; |
There was a problem hiding this comment.
Warum zeigt die LinksShape auf UrlShape und nicht auf LinkShape... das wäre doch wesentlich logischer oder nicht?
Warum trennen wir überhaupt zwischen Link und Url?
| sh:name "data"@en ; | ||
| sh:node dataResourceExtension:UrlShape ; | ||
| sh:order 1 ; | ||
| sh:path dataResourceExtension:data ]; |
There was a problem hiding this comment.
data muss nicht nochmal aufgeführt werden. Das passiert in Gaia-X in dem ServiceAccessPoint, siehe https://github.com/GAIA-X4PLC-AAD/gaia-x-compliant-claims-example/blob/main/src/ServiceAccessPoint-instance.json (statt EDC URL kann ich hier auch jegliche andere Adresse, unter der man das Asset findet angegeben werden)
…ta, update general Signed-off-by: jtdemer <[email protected]>
Signed-off-by: GitHub Action <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the general shape contains some properties that are specific to the marketplace/data ecosystem (contractId, relatedData, etc.) and not domain-specific for simulation data.
The solution to this problem is to move all ecosystem relevant properties to dataResourceExtension.
I have defined the dataResourceExtension as a subclass of the dataresource and then general extended it as a subclass of dataresourceextension. Due to the current convention here in the repo I defined the both general and dataResourceExtension as subclass of gx:DataResource
It is structured as follows:
Dataresourceextension contains now LinksShape and BundleDataShape
General contains now DescriptionShape, DataShape and Range2DShape
From the DataShape I delete the contractID because it is related to polices and needs to be defined not in a shacl.
I also adjusted the LinkShape, urls are now defined in the UrlShape and links to related data at the LinkShape.
Changes should fix this Issue:
#88
Type of change
I would expect that we need to change the ontology structure once at Federated Catalogue.
How Has This Been Tested?
Checklist