-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dataResourceExtension #92
Conversation
…ension -> gaia-x specific Signed-off-by: jtdemer <[email protected]>
Signed-off-by: GitHub Action <[email protected]>
Signed-off-by: jtdemer <[email protected]>
…-AAD/ontology-management-base into dataResourceExtension
Signed-off-by: GitHub Action <[email protected]>
change subClassOf back to gx from dataResourceExtension Signed-off-by: Johannes Demer <[email protected]>
…nstance.json rename file Signed-off-by: Johannes Demer <[email protected]>
rename file Signed-off-by: Johannes Demer <[email protected]>
Signed-off-by: Johannes Demer <[email protected]>
general/general_ontology.ttl
Outdated
@@ -14,7 +14,7 @@ general: a owl:Ontology ; | |||
general:General a owl:Class ; | |||
rdfs:label "Class definition for General" ; | |||
rdfs:comment "General attributes for all assets"@en ; | |||
rdfs:subClassOf gx:DataResource . | |||
rdfs:subClassOf gx:DataResourceExtension . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dataResourceExtension:DataResourceExtension
sh:description "Reference to media data"@en ; | ||
sh:message "Validation of media failed!"@en ; | ||
sh:name "media"@en ; | ||
sh:node dataResourceExtension:UrlShape ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warum zeigt die LinksShape auf UrlShape und nicht auf LinkShape... das wäre doch wesentlich logischer oder nicht?
Warum trennen wir überhaupt zwischen Link und Url?
sh:name "data"@en ; | ||
sh:node dataResourceExtension:UrlShape ; | ||
sh:order 1 ; | ||
sh:path dataResourceExtension:data ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data muss nicht nochmal aufgeführt werden. Das passiert in Gaia-X in dem ServiceAccessPoint, siehe https://github.com/GAIA-X4PLC-AAD/gaia-x-compliant-claims-example/blob/main/src/ServiceAccessPoint-instance.json (statt EDC URL kann ich hier auch jegliche andere Adresse, unter der man das Asset findet angegeben werden)
…ta, update general Signed-off-by: jtdemer <[email protected]>
Signed-off-by: GitHub Action <[email protected]>
Description
Currently, the general shape contains some properties that are specific to the marketplace/data ecosystem (contractId, relatedData, etc.) and not domain-specific for simulation data.
The solution to this problem is to move all ecosystem relevant properties to dataResourceExtension.
I have defined the dataResourceExtension as a subclass of the dataresource and then general extended it as a subclass of dataresourceextension. Due to the current convention here in the repo I defined the both general and dataResourceExtension as subclass of gx:DataResource
It is structured as follows:
Dataresourceextension contains now LinksShape and BundleDataShape
General contains now DescriptionShape, DataShape and Range2DShape
From the DataShape I delete the contractID because it is related to polices and needs to be defined not in a shacl.
I also adjusted the LinkShape, urls are now defined in the UrlShape and links to related data at the LinkShape.
Changes should fix this Issue:
#88
Type of change
I would expect that we need to change the ontology structure once at Federated Catalogue.
How Has This Been Tested?
Checklist