Storm: Fix linting and helm dependency update #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Skowroński <[email protected]> Co-authored-by: Ljubo Nikolic <[email protected]>
pavlovic-ivan
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is an improvement PR
What this PR does / why we need it:
After merging #121 we found a problem with Storm chart during lint and installing process. More info in the comment
Resolves: https://github.com/G-Research/gr-oss/issues/610
The scope of this PR is:
The user is added as co-author of this commit ⭐
values.yamlfrom2.4.0->2.4.0-temurinas the old version is not available any more on https://hub.docker.com/_/storm/tags
1.2.0->1.2.1which will be released and published upon merging this PR on upstream repoAcceptance criteria / Notes for the reviewer: