Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover more methods with tests and slightly improve other tests #34

Merged
merged 9 commits into from
Jul 19, 2023

Conversation

P3ridot
Copy link
Member

@P3ridot P3ridot commented Jul 18, 2023

No description provided.

@P3ridot P3ridot added the Enhancement Improvement to already existing functionality label Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +5.07 🎉

Comparison is base (b9eab97) 71.43% compared to head (27031e5) 76.50%.

❗ Current head 27031e5 differs from pull request most recent head 046c10b. Consider uploading reports for the commit 046c10b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #34      +/-   ##
============================================
+ Coverage     71.43%   76.50%   +5.07%     
- Complexity      132      141       +9     
============================================
  Files            26       26              
  Lines           469      468       -1     
  Branches         52       52              
============================================
+ Hits            335      358      +23     
+ Misses          112       93      -19     
+ Partials         22       17       -5     
Impacted Files Coverage Δ
...utilities/inject/DependencyInjectionException.java 100.00% <ø> (+33.34%) ⬆️
...panda_lang/utilities/inject/InjectorProcessor.java 93.03% <100.00%> (+17.73%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@P3ridot P3ridot force-pushed the tests branch 2 times, most recently from 072f606 to 8fed063 Compare July 18, 2023 20:26
@P3ridot P3ridot changed the title Improve tests Cover more methods with tests and slightly improve other tests Jul 18, 2023
@P3ridot P3ridot force-pushed the tests branch 2 times, most recently from 3839ba2 to 4fe251a Compare July 19, 2023 01:21
@P3ridot P3ridot requested a review from dzikoysk July 19, 2023 01:38
@P3ridot P3ridot force-pushed the tests branch 2 times, most recently from 27031e5 to 1b7ccb3 Compare July 19, 2023 13:54
@dzikoysk dzikoysk merged commit 2bb8bf9 into master Jul 19, 2023
3 checks passed
P3ridot added a commit that referenced this pull request Jul 19, 2023
…34)

* Create test for InjectorProcessor

* Make utility classes in tests private

* Create tests for methods invocation

* Slightly improve AnnotationUtils

* Remove unused DependencyInjectionException constructor

* Assert that method invocation does not throw

* Better line breakings

* Do not rely on order of execution

* General tests cleanup
@P3ridot P3ridot deleted the tests branch April 1, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants