Improve benchmarks

FunnyGuilds · Jul 18, 2023 · 0683bef · 0683bef
1 parent e60fd6b
commit 0683bef
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 13 deletions.
diff --git a/di/src/jmh/java/org/panda_lang/utilities/inject/InstanceConstructionBenchmark.java b/di/src/jmh/java/org/panda_lang/utilities/inject/InstanceConstructionBenchmark.java
@@ -15,10 +15,10 @@
 
 /* JDK17 (I5-8600K OC 4.5 Ghz, 32GB RAM 3200Mhz, Windows 10)
     Benchmark                                  Mode  Cnt        Score       Error   Units
-    InstanceConstructionBenchmark.direct                    thrpt   10  1781363.746 � 5913.192  ops/ms
-    InstanceConstructionBenchmark.injected                  thrpt   10     1691.496 �   27.704  ops/ms
-    InstanceConstructionBenchmark.injectedStatic            thrpt   10     2685.872 �   48.589  ops/ms
-    InstanceConstructionBenchmark.reflection                thrpt   10   102089.754 � 4540.710  ops/ms
+    InstanceConstructionBenchmark.direct                    thrpt   10  1722222.040 � 261518.655  ops/ms
+    InstanceConstructionBenchmark.injected                  thrpt   10     1678.588 �     11.786  ops/ms
+    InstanceConstructionBenchmark.injectedStatic            thrpt   10     2678.599 �     15.572  ops/ms
+    InstanceConstructionBenchmark.reflection                thrpt   10   104147.946 �    336.587  ops/ms
  */
 @Fork(value = 1)
 @Warmup(iterations = 10, time = 2)
@@ -45,7 +45,7 @@ private static class EntityData {
         private final int coins;
         private final float health;
 
-        private EntityData(int coins, float health) {
+        public EntityData(int coins, float health) {
             this.coins = coins;
             this.health = health;
         }

diff --git a/di/src/jmh/java/org/panda_lang/utilities/inject/InstanceConstructionWithFieldsBenchmark.java b/di/src/jmh/java/org/panda_lang/utilities/inject/InstanceConstructionWithFieldsBenchmark.java
@@ -1,6 +1,7 @@
 package org.panda_lang.utilities.inject;
 
 import java.lang.reflect.Constructor;
+import java.lang.reflect.Field;
 import java.util.Arrays;
 import java.util.List;
 import java.util.concurrent.TimeUnit;
@@ -19,10 +20,10 @@
 
 /* JDK17 (I5-8600K OC 4.5 Ghz, 32GB RAM 3200Mhz, Windows 10)
     Benchmark                                            Mode  Cnt        Score       Error   Units
-    InstanceConstructionWithFieldsBenchmark.direct          thrpt   10  1783887.523 � 4646.745  ops/ms
-    InstanceConstructionWithFieldsBenchmark.injected        thrpt   10     1302.971 �    8.086  ops/ms
-    InstanceConstructionWithFieldsBenchmark.injectedStatic  thrpt   10     1697.869 �   10.716  ops/ms
-    InstanceConstructionWithFieldsBenchmark.reflection      thrpt   10    15222.960 �  133.865  ops/ms
+    InstanceConstructionWithFieldsBenchmark.direct          thrpt   10  1786947.021 �   9127.717  ops/ms
+    InstanceConstructionWithFieldsBenchmark.injected        thrpt   10     1328.763 �      4.493  ops/ms
+    InstanceConstructionWithFieldsBenchmark.injectedStatic  thrpt   10     1707.824 �     16.935  ops/ms
+    InstanceConstructionWithFieldsBenchmark.reflection      thrpt   10    25232.337 �     48.927  ops/ms
  */
 @Fork(value = 1)
 @Warmup(iterations = 10, time = 2)
@@ -36,9 +37,9 @@ private static class Entity {
         private final String name;
 
         @Inject
-        public EntityData data;
+        private EntityData data;
         @Inject
-        public EntityStorage storage;
+        private EntityStorage storage;
 
         public Entity(int id, String name) {
             this.name = name;
@@ -79,8 +80,15 @@ public void direct(DIState state) {
     @Benchmark
     public void reflection(DIState state) throws Throwable {
         Entity object = state.constructor.newInstance(123456789, "PandaIsCool");
-        Entity.class.getField("data").set(object, state.entityDataSupplier.get());
-        Entity.class.getField("storage").set(object, state.entityStorage);
+        state.constructor.setAccessible(true);
+
+        Field dataField = Entity.class.getDeclaredField("data");
+        dataField.setAccessible(true);
+        dataField.set(object, state.entityDataSupplier.get());
+
+        Field storageField = Entity.class.getDeclaredField("storage");
+        storageField.setAccessible(true);
+        storageField.set(object, state.entityStorage);
     }
 
     @Benchmark