feat: Remove bech32 #1385
Merged
feat: Remove bech32 #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rodrigobranas
commented
Jun 20, 2024
rodrigobranas
commented
- Closes Remove bech32 addresses completely #1309
rodrigobranas
requested review from
luizstacio,
pedronauck,
LuizAsFight,
helciofranco and
arthurgeron
as code owners
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 62.46% | 3223/5160 |
| 🔴 | Branches | 41.99% | 621/1479 |
| 🔴 | Functions | 47.11% | 684/1452 |
| 🟡 | Lines | 63% | 3106/4930 |
Test suite run success
243 tests passing in 71 suites.
Report generated by 🧪jest coverage report action from 2d3de68
LuizAsFight
requested changes
Jun 21, 2024
arthurgeron
requested changes
Jun 21, 2024
packages/app/src/systems/Network/components/NetworkSelector/NetworkSelector.test.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/systems/Account/components/FuelAddress/FuelAddress.test.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/systems/Account/components/FuelAddress/FuelAddress.tsx
Outdated
Show resolved
Hide resolved
LuizAsFight
requested changes
Jun 21, 2024
LuizAsFight
requested changes
Jun 21, 2024
LuizAsFight
requested changes
Jun 21, 2024
arthurgeron
approved these changes
Jun 24, 2024
|
LGTM! 🚀 |
LuizAsFight
approved these changes
Jun 24, 2024
LuizAsFight
pushed a commit
that referenced
this pull request
Jun 28, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## [email protected] ### Minor Changes - [#1397](#1397) [`3966aa92`](3966aa9) Thanks [@rodrigobranas](https://github.com/rodrigobranas)! - Improved error handling and including location informations to support better understanding about the causes of erros - [#1385](#1385) [`d49b9efe`](d49b9ef) Thanks [@rodrigobranas](https://github.com/rodrigobranas)! - Support for Bech32 addresses has been removed and replaced with b256 (hex) addresses throughout the wallet screen components. All addresses, both existing and new, will now be displayed in the b256 format. While Bech32 addresses can still be used on the send screen, they will be automatically converted and processed as b256 internally. QR codes on the receive screen will now encode addresses in the b256 format. ### Patch Changes - Updated dependencies \[]: - @fuel-wallet/[email protected] ## @fuel-wallet/[email protected] ## @fuel-wallet/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.