feat: validate asset names during e2e contract tests #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arthurgeron
commented
May 28, 2024
arthurgeron
commented
- Added aria labels to Recipient Sender and Asset Name on transaction approval screen;
- Create util for checking text content on multiple aria labels;
- Validate all asset names during e2e contract tests on the transaction approval screen, executes validation on all e2e contract test files.
arthurgeron
requested review from
luizstacio,
pedronauck,
LuizAsFight and
helciofranco
as code owners
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 62.54% | 3227/5160 |
| 🔴 | Branches | 41.92% | 625/1491 |
| 🔴 | Functions | 47.25% | 686/1452 |
| 🟡 | Lines | 63.06% | 3109/4930 |
Test suite run success
243 tests passing in 71 suites.
Report generated by 🧪jest coverage report action from 186693a
LuizAsFight
requested changes
May 31, 2024
packages/app/src/systems/Asset/components/AssetsAmount/AssetsAmount.tsx
Outdated
Show resolved
Hide resolved
LuizAsFight
approved these changes
Jun 28, 2024
LuizAsFight
pushed a commit
that referenced
this pull request
Jul 8, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## [email protected] ### Minor Changes - [#1403](#1403) [`d4f89b17`](d4f89b1) Thanks [@rodrigobranas](https://github.com/rodrigobranas)! - re-enabling faucet e2e tests - [#1402](#1402) [`b8b03704`](b8b0370) Thanks [@rodrigobranas](https://github.com/rodrigobranas)! - Converted the address from bech32 to b256 on faucet link ### Patch Changes - [#1319](#1319) [`e3bf65aa`](e3bf65a) Thanks [@arthurgeron](https://github.com/arthurgeron)! - - Added aria labels to Recipient Sender and Asset Name on transaction approval screen; - Validate all asset names during e2e contract tests on the transaction approval screen - [#1408](#1408) [`24840bfe`](24840bf) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - TransactionList breaking when have a failed transaction - Updated dependencies \[]: - @fuel-wallet/[email protected] ## @fuel-wallet/[email protected] ## @fuel-wallet/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.