Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add further snippets with new infrastructure #3195

Open
wants to merge 116 commits into
base: next
Choose a base branch
from
Open

docs: add further snippets with new infrastructure #3195

wants to merge 116 commits into from
+1,467 −230

Conversation

maschad
Copy link
Member

@maschad maschad commented Sep 22, 2024 •
edited
Loading

Summary

This PR builds on the work @arboleya did in #2651 by introducing some more snippets that have been migrated to the new infra. Once this is merged into that branch then the docs can be refactored to use the folder structure in #3205

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

arboleya and others added 30 commits July 2, 2024 14:37
@arboleya
Starting new code-snippets app
28c0b1c
@arboleya
Porting getting-started snippets
48bbcba
@arboleya
Ignoring new app in changesets
5b4f678
@arboleya
Adding changeset
a45a02a
@arboleya
Ignoring wrapped snippets files (generated)
b382460
@arboleya
Ignore test files trying to import files that haven’t been built yet
a83e65c
@Torres-ssf
Merge branch 'master' into aa/feat/infra-for-new-snippets
41c2943
@Torres-ssf
Merge branch 'master' into aa/feat/infra-for-new-snippets
596242c
@arboleya
Using real code/file rather than code-string
89bd596
@arboleya
Adding example using launchTestNode and LOCAL_NETWORK_URL overrides
89348f9
@arboleya
Skipping until forc workspace has at least one member
0b790b7
@arboleya
Renaming variable
125aaad
@arboleya
Fixing regex
3406527
@arboleya
Ignoring lint issues individually
01f8558
@arboleya
Removing from browser group
b63c163
@arboleya
Lintfix
36dbe16
@arboleya
Merge branch 'master' into aa/feat/infra-for-new-snippets
663d9ce
@arboleya
Restoring console after snippet
9134334
@arboleya
Keeping wrapper free from weird hacks
168f124
@arboleya
Adding mock utility
3dd1e3f
@arboleya
Using mocking utility
6ed91e2
@arboleya
Validating if nertworkUrl was properly mocked
939f9d6
@arboleya
Merge branch 'master' into aa/feat/infra-for-new-snippets
571e85c
@arboleya
Mock provider instead?
f795f00
@arboleya
Mocking only for localhost
5732d8c
@arboleya
Adjusting snippets
020022f
@arboleya
Wrapping snippet in a try/catch
1388057
@arboleya
Merge branch 'master' into aa/feat/infra-for-new-snippets
48f1176
@arboleya
Adding blank spaces
98b02e1
@arboleya
Removing mocking utility
ea01d46
@maschad maschad marked this pull request as ready for review September 27, 2024 22:58
@maschad maschad marked this pull request as draft September 28, 2024 17:23
@maschad maschad marked this pull request as ready for review September 30, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@maschad maschad

Labels
docs Requests pertinent to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maschad @arboleya @Torres-ssf