Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update pnpm to 9.7.1 #3000

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

ci: update pnpm to 9.7.1 #3000

wants to merge 6 commits into from

Conversation

maschad
Copy link
Member

@maschad maschad commented Aug 21, 2024

Summary

I was tired of seeing the prompt to update pnpm 😄

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@maschad
Copy link
Member Author

maschad commented Aug 21, 2024

@petertonysmith94 I'm not quite sure how to update this on Vercel deployments, I'm not seeing any workflow files related to it nor am I seeing it on the deployment settings.

@maschad maschad self-assigned this Aug 21, 2024
arboleya
arboleya previously approved these changes Aug 21, 2024
nedsalk
nedsalk previously approved these changes Aug 22, 2024
danielbate
danielbate previously approved these changes Aug 22, 2024
@arboleya
Copy link
Member

@maschad I went down this rabbit hole and clicked every link two levels deep, to no avail:

Ultimately, it suggests turning off the strictness version in .npmrc, which doesn't seem like the best solution.

I did everything but this, and nothing worked.

Torres-ssf
Torres-ssf previously approved these changes Aug 22, 2024
Dhaiwat10
Dhaiwat10 previously approved these changes Aug 22, 2024
@maschad
Copy link
Member Author

maschad commented Aug 22, 2024

@maschad I went down this rabbit hole and clicked every link two levels deep, to no avail:

Ultimately, it suggests turning off the strictness version in .npmrc, which doesn't seem like the best solution.

I did everything but this, and nothing worked.

Thanks for taking a look into this @arboleya, reading through that thread that you shared it seems that's the only available workaround at the moment, although I agree with you, it's not a real solution 😕

@arboleya
Copy link
Member

@maschad Yes, annoying as it is, this is a low-priority thing. I'd say I prefer to keep using an outdated version rather than turn off strictness and risk us all running different versions, which could cause issues.

@maschad
Copy link
Member Author

maschad commented Aug 22, 2024

@maschad Yes, annoying as it is, this is a low-priority thing. I'd say I prefer to keep using an outdated version rather than turn off strictness and risk us all running different versions, which could cause issues.

Agree here @arboleya , I'll move this PR to draft until a better resolution can be found.

@maschad maschad marked this pull request as draft August 22, 2024 17:51
Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ❌ Failed (Inspect) Sep 23, 2024 8:21pm
ts-docs ❌ Failed (Inspect) Sep 23, 2024 8:21pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 23, 2024 8:21pm

Copy link

codspeed-hq bot commented Sep 23, 2024

CodSpeed Performance Report

Merging #3000 will improve performances by 97.06%

Comparing mc/chore/update-pnpm-9.7.1 (ed91575) with master (cab11ef)

Summary

⚡ 1 improvements
✅ 20 untouched benchmarks

Benchmarks breakdown

Benchmark master mc/chore/update-pnpm-9.7.1 Change
should successfully execute a contract deploy 191.8 ms 97.3 ms +97.06%

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.17%(+0%) 71.81%(+0%) 75.77%(+0%) 77.28%(+0%)
Changed Files:

Coverage values did not change👌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants