Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove serde feature from the fuel-tx crate #843

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Sep 27, 2024

Closes #832

After we introduced the Upgrade transaction and started to use postcard to encode the consensus parameters, we basically made the serde feature required.

Part of our codebase already derived serde::Seriliaze and serde::Deserialize regardless of the serde feature. This PR removes the serde feature and enables it for the fuel-tx crate by default under the alloc feature.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog

Before requesting review

  • I have reviewed the code myself

@xgreenx xgreenx requested a review from a team September 27, 2024 09:18
@xgreenx xgreenx self-assigned this Sep 27, 2024
Copy link
Member

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, curious if this was tested with the network upgrader which we ran into issues with serde? :)

@xgreenx
Copy link
Collaborator Author

xgreenx commented Sep 27, 2024

No, I haven't tested it, but since we added assert into network ugprader itself, we will see if something is wrong=)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove serde feature from the fuel-tx crate
3 participants