feat(publisher): Add an example of streaming contract events. DS-64 #224
+400
−301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostman
force-pushed
the
mw/ds-64/contract-events-example
branch
from
ad7ef56
to
7fab01c
Compare
lostman
force-pushed
the
mw/ds-64/contract-events-example
branch
from
7fab01c
to
0948910
Compare
lostman
changed the title
lostman
requested review from
luizstacio,
pedronauck,
Jurshsmith and
0xterminator
as code owners
Jurshsmith
reviewed
Sep 27, 2024
Comment on lines
+177
to
+184
| let mut receipt_stream = fuel_streams::Stream::<Receipt>::new(client).await; | ||
|
|
||
| receipt_stream.with_filter( | ||
| ReceiptsBurnSubject::new().with_contract_id(Some(contract_id.into())), | ||
| ); | ||
| receipt_stream.with_filter( | ||
| ReceiptsCallSubject::new().with_from(Some(contract_id.into())), | ||
| ); |
There was a problem hiding this comment.
This might be better from a readability standpoint:
Suggested change
| let mut receipt_stream = fuel_streams::Stream::<Receipt>::new(client).await; | |
| receipt_stream.with_filter( | |
| ReceiptsBurnSubject::new().with_contract_id(Some(contract_id.into())), | |
| ); | |
| receipt_stream.with_filter( | |
| ReceiptsCallSubject::new().with_from(Some(contract_id.into())), | |
| ); | |
| let mut receipt_stream = fuel_streams::Stream::<Receipt>::new(client).await; | |
| let receipt_stream = receipt_stream.with_filter( | |
| ReceiptsBurnSubject::new().with_contract_id(Some(contract_id.into())), | |
| ).with_filter( | |
| ReceiptsCallSubject::new().with_from(Some(contract_id.into())), | |
| ). | |
| // other with_filters come here |
pedronauck
reviewed
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.