Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reproducibility issues #187
base: develop
Are you sure you want to change the base?
Fix reproducibility issues #187
Changes from 1 commit
4f848cd
85700f1
934aff7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work on even on Debian.
Any suggestion @mzf-guest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed! This code does not work when
SOURCE_DATE_EPOCH
is not defined by the build chain. Good catch! and sorry the miss.The Makefile example from this page seems to work better, at least in a minimal test. But I can't make it work from the Makefile.am file. When running
autoreconf -i
, theifeq
is recognized as a AM command instead of copying it verbatim in the Makefile.Unfortunately, I'm not very skilled with autotools. Do you have any hints?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahah, no, I faced the exact same issue. Maybe this should be put a static makefile, like
Makefile.date
. And then we'd replacedate
bymake -f Makefile.date date
withThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any update about this @mzf-guest?