-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor operator to make use of the fdb-kubernetes-monitor API #2075
Merged
johscheuer
merged 2 commits into
FoundationDB:main
from
johscheuer:operator-refactor-for-monitor-api
Jun 25, 2024
Merged
Refactor operator to make use of the fdb-kubernetes-monitor API #2075
johscheuer
merged 2 commits into
FoundationDB:main
from
johscheuer:operator-refactor-for-monitor-api
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
johscheuer
commented
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fdb-kubernetes-monitor side is merged.
johscheuer
force-pushed
the
operator-refactor-for-monitor-api
branch
from
June 24, 2024 15:19
c0b2117
to
6210bd1
Compare
nicmorales9
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Same failure as in the other ones:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring for making use of the moved constants and structs here: apple/foundationdb#11464
Type of change
Please select one of the options below.
Discussion
I put this as draft until the PR above is merged.
Testing
Ran unit tests and e2e tests.
Documentation
Follow-up