Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: pass along Jest testNamePattern argument if provided #182

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

danibrutal
Copy link
Contributor

Description

Adds ability to pass along Jest's testNamePattern argument if provided when running the tests

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Adding or updating CI (Actions)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My code follows the style guidelines of this project (I have run yarn prettier:apply)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (I have run yarn test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Screenshots (for visual changes):

Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: e45f90c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-native-owl Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-owl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 8:36pm

};

const testPathPatternOption: Options = {
alias: 'p',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the alias here to make it consistent with Jest documentation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While technically a breaking change, this is a new feature that many users haven't upgraded to and its only a CLI and not a production dep, I think its fine to go ahead and merge.

@carbonrobot carbonrobot merged commit 15f3de0 into FormidableLabs:main Oct 3, 2024
6 of 7 checks passed
@github-actions github-actions bot mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants