Cleanup compiler warnings #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleanups several lingering compiler warnings.
Almost all warnings were in fortran codes
Most warnings were "uninitialized variables" that occur when a variable is set in an
if ... elseif ....branch without anelseto catch any default. These were mostly fixed by including an else branch that will exit code.The "missing terminating character` still occurs with ninja/cmake
TEST files still have numerous warnings involving
sprintf(warnings suggest usingsnprintfinstead).One
set but not usedvariable warning left un-fixed infclaw2d_convenience.c. @cburstedde - can you fix this?