Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP : Add SWE on the sphere example #337

Merged
merged 55 commits into from
Jul 11, 2024
Merged

WIP : Add SWE on the sphere example #337

merged 55 commits into from
Jul 11, 2024

Conversation

donnaaboise
Copy link
Member

@donnaaboise donnaaboise commented Jun 24, 2024 •
edited
Loading

This clawpack example solves the shallow water equations on the sphere.

  • Works with cubed-sphere, latlong and pillowshere grid for flat bathymetry
  • Works with pillowshere with non-flat bathymetry
  • Regression test included.

Unresolved issues :

  • Autoconf build does not produce same results as cmake build when running claw-version=4. This can be seen even just running using regression.ini.
  • Cubed-sphere mesh does not yet handle non-flat bathymetry

Fixed : adaptivity works on pillow sphere.

@donnaaboise
(swe/sphere) WIP : Initial commit of files
eabe1d4
@donnaaboise
(sphere/swe) WIP : Code compiles
41676ae
@donnaaboise
(shallow/sphere) Code is running and working for cubed sphere and lat…
86405f7 
…long
@donnaaboise
(shallow/sphere) Example now working
c3b9da7
@donnaaboise
(swe/sphere) WIP : Still working on scaling
43a15dd
@donnaaboise
shallow/sphere) WIP : SWE code working on unit sphere
7a5e642
@donnaaboise
(shallow/sphere) Minor updates, after deleting entire directory!
c5b4874
@donnaaboise
(shallow/sphere/1d) Add 1d refernece solution (requires Clawpack)
f50dc60
@donnaaboise
WIP : Still working on conservation
1d53342
@donnaaboise
(shallow/sphere) Try applying project in source term only
36b5fa1
@donnaaboise
(shallow/sphere) Fix options handling
c1e29c2
@donnaaboise
(shallow/sphere) WIP : Working on sphere example
78c9c8a
@donnaaboise
Update signature for fwave Riemann solvers
55f3cdc
@donnaaboise
(transport/sphere) Update fwave signature
7eb056d
@donnaaboise
(shallow/sphere) WIP : Still need to fix transverse solver
4a2421c
@donnaaboise
(clawpack/shallow/sphere) WIP : Adding fwave option
18b1689
@donnaaboise
(swe/sphere) Fix fwave Riemann solver - some off with beta(2) computa…
bcae614 
…tion
@donnaaboise
(clawpack46) Add fwave Rieman solver headers
54a8a4b
@donnaaboise
(clawpack46) Use a single flux2 for both original and fwave code
8140544
@donnaaboise
(swe sphere) Update to Matlab files
c6dace4
@donnaaboise
(shallow/sphere) Fwave solver working
da68c40
@donnaaboise
(clawpack46) Minor updates to use same flux2 routine for both wave an…
d830378 
…d fwave approaches
@donnaaboise
(shallow/sphere) Extract code from stash; use single flux2 for fwaves…
b612bd8 
…; don't pass in maux
@donnaaboise
(clawpack/transport) Modify signature for fwave solvers - do not pass…
1f8e806 
… in maux
@donnaaboise
(clawpack46) Update signature for fwaves routines - it is now the sav…
92b656c 
…e as rpn2
@donnaaboise
Remove assertions that check whether extension has been initialized m…
dc4b11e 
…ore than once
@donnaaboise
(shallow/sphere) Sorted out remaining fwaves bugs
1a09efb
@donnaaboise
(shallow/2d/sphere) Fix beta calculation in transverse solver"
17ff17c
@donnaaboise
(clawpack/shallow/sphere) WIP : Sphere works; no bathymetry example
26443ae
@donnaaboise
(shallow/sphere/sphere_ridge) WIP : Added sphere with ridge problem
eb4c65f
@donnaaboise
(shallow/sphere) WIP : Update to sphere problem with flat bathymetry
ccb8677
@donnaaboise
(clawpack/shallow/2d/rp) Add conservation fix code
1a02baf
@donnaaboise
(clawpack/shallow/2d/sphere_ridge) WIP : Add Matlab code to compute n…
63a1d50 
…on-dimensinonal quantities
@donnaaboise
clawpack/shallow/2d/sphere_ridge) WIP : Minor update to non-dimensial…
20f6375 
…ization
@donnaaboise
(shallow/sphere) WIP : Combine flat and bump problems
c7bd2ad
@donnaaboise
(shallow/sphere/1d_ridge) WIP : Add 1d refernce solution
8df945a
@donnaaboise
(clawpack/shallow/sphere) WIP : Working on sphere code
6130b71
@donnaaboise
(clawpack/shallow/sphere) WIP : 1d and 2d results agree for constant …
a875d27 
…bathymetry
@donnaaboise
(shallow/sphere) WIP : Bathymetry example is close to working
7d5f2a7
@donnaaboise
(clawpack/advection/2d/sphere) Minor updates to graphics
a44a6c9
@donnaaboise
(clawpack/shallow/2d/sphere) Updates to shallow water on the sphere
1e0acda
@donnaaboise
(shallow/2d/sphere) WIP : Add claw 5 routines
3d0d449
@donnaaboise
(shallow/2d/sphere) WIP : Update to add 5.0 routines
a031562
@donnaaboise
(clawpack/shallow/2d/sphere) Clawpack 5 version works
9ac848b
@donnaaboise
(clawpack/shallow/2d/sphere) WIP : Working on autoconf build
0f31d46
@donnaaboise
(fc2d_clawpack46) Minor updates to work with SWE on sphere
b5d80ff
@donnaaboise
(fc2d_clawpack5) Update to include fwaves version
0d295e7
@donnaaboise
(clawpack/shallow/2d/sphere) Add CI regression testing
0309ed0
@donnaaboise
(clawpack/shallow/2d/sphere) Update to CMakelists
0be0ef6
@donnaaboise
(clawpack/shallow/2d/sphere) Update regression testing
f800c08
@donnaaboise
(clawpack/shallow/2d/sphere_ridge) Remove separate application for ri…
e65e9a0 
…dge example; everythign is in the sphere example
@donnaaboise
Merge branch 'develop-3d' into test_merge
26e6a7b
@donnaaboise
(clawpack/shallow/2d/sphere) WIP : Work on ridge example; works on si…
136e299 
…ngle pillow grid
@donnaaboise
Revert to develop-3d version of global options storing (only one stor…
a73c7fd 
…e per options handling)
@donnaaboise
(clawpack/2d/shallow/sphere) Update regression tests
cc84495
@scottaiton scottaiton merged commit 084afac into ForestClaw:develop-3d Jul 11, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donnaaboise @scottaiton