Progress on 3D - domain_indirect_neighbors #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburstedde
reviewed
Sep 21, 2023
| *rfaceno = pi + 5; | ||
| *rblockno = pi + P4EST_HALF; | ||
| *rpatchno = pi + P4EST_HALF + 1; | ||
| *rfaceno = pi + P4EST_CHILDREN + 1; /* P4EST_CHILDREN == 2 * P4EST_HALF */ |
There was a problem hiding this comment.
please can you use P4EST_CHILDREN only if referring to the volumetric refinement? In this code, it seems more to the point to write pi + P4EST_HALF + 1 + P4EST_HALF.
cburstedde
reviewed
Sep 21, 2023
| fclaw2d_block_t *block; | ||
| fclaw2d_domain_indirect_t *ind; | ||
| fclaw2d_patch_relation_t prel; | ||
| p4est_wrap_t *wrap = (p4est_wrap_t *) domain->pp; | ||
| p4est_ghost_t *ghost = p4est_wrap_get_ghost (wrap); | ||
|
|
||
| num_exc = domain->num_exchange_patches; | ||
| data_size = P4EST_FACES * 6 * sizeof (int); | ||
| face_info_size = 2 + P4EST_CHILDREN; /* P4EST_CHILDREN == 2 * P4EST_HALF */ |
There was a problem hiding this comment.
As above, this identity should not be used. P4EST_HALF should be used when referring to small face neighbors, and P4EST_CHILDREN when referring to children. Thanks for the good work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add the 3D version of
domain_indirect_neighbors, that queries face neighbors of ghost patches which reside on another process. The maximum amount of face neighbors (2 in 2D, 4 in 3D) is parameterized by P4EST_HALF.