-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected typos, dates and versions in the index, setup and tips. #3
Conversation
and some language improvements
more typos corrected
… also typos where found
…ding of responsibility of main method
Added week9, sealed shape project in topics/code as example and included in description. |
<<parent> | ||
<groupId>io.github.fontysvenlo</groupId> | ||
<artifactId>informaticspom</artifactId> | ||
<version>1.2</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be here 1.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
@@ -9,7 +9,7 @@ A maven repository is a server that provides ready built maven 'artifacts', such | |||
|
|||
There is a default repository, called https://mvnrepository.com/repos/central[maven central]. You (as a team or company) can have your own repository. | |||
|
|||
If you look at a maven repository you will see that it is organized along the three axes: groupId, artifactId and version. We have published our Fontys Venlo *informatics pom* under groupId io.github.fontysvenlo, artifactId informaticspom and current (February 2023) 0.9. | |||
If you look at a maven repository you will see that it is organized along the three axes: groupId, artifactId and version. We have published our Fontys Venlo *informatics pom* under groupId io.github.fontysvenlo, artifactId informaticspom and current (February 2024) 1.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not version 1.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
topics/code/sealedshapes/pom.xml
Outdated
<version>5.2.0</version> | ||
<groupId>io.github.fontysvenlo</groupId> | ||
<artifactId>informaticspom</artifactId> | ||
<version>1.2</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again here 1.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes ;-(
Getting numbers right with regex is dangerous, but you are right in all cases. |
Updates as promised, also on versions and dates.
Closes nothing yet.