Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected typos, dates and versions in the index, setup and tips. #3

Merged
merged 33 commits into from
Feb 20, 2024

Conversation

homberghp
Copy link
Contributor

Updates as promised, also on versions and dates.

Closes nothing yet.

@homberghp
Copy link
Contributor Author

Added week9, sealed shape project in topics/code as example and included in description.

@homberghp homberghp closed this Jan 25, 2024
@Bonajo Bonajo reopened this Feb 19, 2024
<<parent>
<groupId>io.github.fontysvenlo</groupId>
<artifactId>informaticspom</artifactId>
<version>1.2</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be here 1.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@@ -9,7 +9,7 @@ A maven repository is a server that provides ready built maven 'artifacts', such

There is a default repository, called https://mvnrepository.com/repos/central[maven central]. You (as a team or company) can have your own repository.

If you look at a maven repository you will see that it is organized along the three axes: groupId, artifactId and version. We have published our Fontys Venlo *informatics pom* under groupId io.github.fontysvenlo, artifactId informaticspom and current (February 2023) 0.9.
If you look at a maven repository you will see that it is organized along the three axes: groupId, artifactId and version. We have published our Fontys Venlo *informatics pom* under groupId io.github.fontysvenlo, artifactId informaticspom and current (February 2024) 1.2.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not version 1.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

<version>5.2.0</version>
<groupId>io.github.fontysvenlo</groupId>
<artifactId>informaticspom</artifactId>
<version>1.2</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again here 1.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes ;-(

@ibrahimko ibrahimko merged commit 91177d5 into FontysVenlo:main Feb 20, 2024
2 checks passed
@homberghp
Copy link
Contributor Author

Getting numbers right with regex is dangerous, but you are right in all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants